Repository navigation
feat: implement issues #833, #834, #835, #836 - #904
Merged
Kingsman-99 merged 2 commits intoSep 30, 2026
Merged
Conversation
…split#835, Stellar-split#836 Stellar-split#836 — Payment fallback recipient - Add set_fallback_recipient(caller, invoice_id, recipient, fallback) entry point - During release, if a recipient is locked and a fallback is configured, funds are routed to the fallback address instead of accumulating to UnreleasedFunds - Storage key: fallback_recipient_key(invoice_id, recipient) - Events: fallback_set, fallback_used Stellar-split#835 — Multi-signature invoice creation (N-of-M co-signer approval) - Add cosign_invoice(signer, invoice_id) entry point - Add get_cosign_status(invoice_id) -> (approvals, required) entry point - At creation, co_signers + required_signatures config is persisted for the new cosign_invoice / get_cosign_status flow - Storage keys: multisig_required_key, multisig_signers_key, multisig_approvals_key - Events: invoice_cosigned, invoice_cosign_complete - Errors: SignerNotAuthorized (72), AlreadySigned (73) Stellar-split#834 — On-chain invoice sentiment analysis - Add submit_sentiment(payer, invoice_id, positive) entry point (payer must have contributed; one vote per payer) - Add get_sentiment(invoice_id) -> (positive_count, negative_count) entry point - Storage keys: sentiment_positive_key, sentiment_negative_key, payer_sentiment_key - Event: sentiment_submitted - Reuses existing AlreadyRated (24) error for double-vote Stellar-split#833 — Creator bankruptcy protection - create_invoice now panics with CreatorLocked (74) if creator has pending disputes - raise_dispute increments creator dispute count and sets creator_lock_key=true - resolve_dispute decrements dispute count; unlocks creator when count reaches 0 - Add get_creator_lock_status(creator) and unlock_creator(caller, invoice_id) entry points - Storage keys: creator_lock_key, creator_dispute_count_key - Events: creator_locked, creator_unlocked - Error: CreatorLocked (74) Tests: full coverage for all four features in test.rs
|
@Danieljyde Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#836 — Payment fallback recipient
#835 — Multi-signature invoice creation (N-of-M co-signer approval)
#834 — On-chain invoice sentiment analysis
#833 — Creator bankruptcy protection
Tests: full coverage for all four features in test.rs
close #833
close #834
close #835
close #836