Repository navigation
Implement invoice deadline soft-lock during active dispute #225
Description
Label: complexity: high
Points: 200
Description
If dispute arbitration is implemented (separate issue), an invoice's deadline could pass while a dispute is being arbitrated, triggering an unwanted automatic refund mid-arbitration. This issue freezes the deadline clock during an active dispute.
Technical Context
Involves lib.rs refund() — when checking env.ledger().timestamp() > invoice.deadline, also check a disputed flag (from the dispute arbitration feature) and block refund eligibility entirely while disputed, regardless of how far past the deadline the ledger time has advanced.
Acceptance Criteria
-
refund()panics with"invoice under dispute"instead of processing whiledisputed == true, even past the deadline - Once the dispute resolves (cleared), normal deadline-based refund eligibility resumes immediately
- Non-disputed invoices are completely unaffected by this change
- Test: disputed invoice past deadline blocks refund; resolving the dispute then allows refund to proceed
- All existing cargo tests pass
-
cargo clippypasses with zero warnings
Activity
Dev-ElvisTobi commentedon Jun 25, 2026
@BigElv has applied to work on this issue as part of the Stellar Wave Program's 6th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @BigElv to this issue.
Komelove commentedon Jun 25, 2026
@Komelove has applied to work on this issue as part of the Stellar Wave Program's 6th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Komelove to this issue.
johnsaviour56-ship-it commentedon Jun 25, 2026
@johnsaviour56-ship-it has applied to work on this issue as part of the Stellar Wave Program's 6th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @johnsaviour56-ship-it to this issue.
drips-wave commentedon Jun 25, 2026
Congratulations, @johnsaviour56-ship-it! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 30, 2026.
🧑💻 @johnsaviour56-ship-it: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Jun 25, 2026
🦊 GrantFox — @johnsaviour56-ship-it has been assigned to this issue as part of the Official Campaign campaign!
Next steps:
Closes #225)Good luck! Track your progress on GrantFox.
grantfox-oss commentedon Jun 27, 2026
🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign campaign!
@johnsaviour56-ship-it's PR #254 was approved and merged by @Kingsman-99.
🏆 @johnsaviour56-ship-it: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (436 total points). Track your full progress on GrantFox.
👏 Great work, @johnsaviour56-ship-it! Keep contributing to Stellar-split.
drips-wave commentedon Jun 27, 2026
This issue has been completed by @johnsaviour56-ship-it as part of the Stellar Wave Program's 6th Wave 🥳
😎 @johnsaviour56-ship-it: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.