Fix click-through hit testing#5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes click-through hit testing so OverlayInputMode.ClickThrough returns HTTRANSPARENT for WM_NCHITTEST, aligning explicit hit-test behavior with WS_EX_TRANSPARENT semantics.
Changes:
- Update input-region resolution to treat
ClickThroughas always pass-through. - Add a Windows integration test asserting
WM_NCHITTESTreturnsHTTRANSPARENTin click-through mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/ModernOverlay/OverlayWindow.cs |
Adjusts ResolveInputRegion to return pass-through for ClickThrough, ensuring WM_NCHITTEST maps to HTTRANSPARENT. |
tests/ModernOverlay.Tests/OverlayWindowThreadingTests.cs |
Adds a regression test validating WM_NCHITTEST behavior for click-through overlays. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OverlayInputMode.ClickThrough so WM_NCHITTEST returns HTTRANSPARENT directly instead of HTCLIENT. This keeps the explicit hit-test path aligned with WS_EX_TRANSPARENT behavior. Validation: dotnet test tests\ModernOverlay.Tests\ModernOverlay.Tests.csproj --configuration Debug --filter ClickThroughNcHitTestReturnsTransparent.