feat: implement fire spreading - #497
Draft
stuffpicklesays wants to merge 2 commits into
Draft
Conversation
Contributor
|
Will you continue working on it and what is the blocker? |
Contributor
Author
|
Yeah, sorry I've been busy recently but will have a work on it now. Main blocker is getting this PR merged into the extractor because I don't want to start implementing anything until I'm sure the way I've done it is right |
Contributor
|
It will only be merged with your PR but I can do a small review of it |
Contributor
Author
|
oh okay thanks alot, didn't realise that's how it works. No need to do a review, not much has changed since you reviewed before. Gonna continue working on this now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Draft PR, still in progress
This PR aims to work towards a fire spreading system which both is optimised and has parity with vanilla
How this was tested
To be tested in game
Checklist
Additional notes