Repository navigation
ScriptDev 1.1.1 - #266
Merged
Merged
ScriptDev 1.1.1#266
Conversation
viktor-ferenczi
commented
Oct 21, 2026
viktor-ferenczi
left a comment
Collaborator
Author
There was a problem hiding this comment.
Fix before merge: the new <Description> is 1195 characters, over the hub's 1000-character limit. Pulsar cuts it in the middle of the Discord link and drops the support links (Medium, see below). Everything else in this bump looks fine.
Scope: version bump re-review of hub PR head e48173f, Plugins/ScriptDev.xml, target viktor-ferenczi/se-script-dev, direct range 2dce778..60b98b4 (2 commits, 13 paths, +146/−69).
Findings
Medium: Description exceeds 1000 characters and gets truncated in the plugin list
- Evidence: the hub
<Description>is 1195 characters; at the base pin it was 705.SamplePlugin.xmldocuments a 1000-character maximum, and Pulsar Legacy (v2.4.3,Legacy/Extensions/PluginData.cs,CapLength(pluginData.Description, 1000)) hard-cuts the text there before it detects links. - Consequence: the SE1 details panel shows
For support join the SE Mods Discord:followed by a loneh. The Discord invite, Patreon and PayPal links and the closing line are lost. - Fix: shorten the Description to 1000 characters or less, for example by tightening the new Publishing paragraph. Mirror the change in the repo's backup
ScriptDev.xml, which has the same text. - The hub validator (
test.py) does not check this length, so CI passing does not catch it.
Manifest
- The only changes are
Tooltip,DescriptionandCommit.Id(also the repo, noRepoId),SourceDirectories(Shared,ClientPlugin), no NuGet/assets/dependencies: unchanged. python3 test.py Pluginsat the PR head:All files validated.- Apart from
<Commit>, the repo's backupScriptDev.xmlat60b98b4has the same Tooltip and Description as the hub manifest.
Repository and pin provenance
60b98b4is the tip ofmain(origin/HEAD), so it is reachable and there is no drift.- Commits:
35c28c8"ScriptDev 1.1.1: Publish button next to Load Game, settings fixes, docs (#8)" and60b98b4"README: Pulsar Discord instead of Plugin Loader".
Security
- Compiled code changes (
MainMenuPatch.cs,PluginConfigDialog.cs,Tracker.cs#L139) are GUI layout and one config gate. They add no new networking, file access, process execution, reflection or dynamic code. - No package, project-reference or MSBuild reference changes.
Version.Build.propsonly bumps the version to 1.1.1. - The six new files are PNG screenshots under
Docs/images/(fileconfirms PNG data). They sit outsideSourceDirectories, so the loader never compiles or loads them. No managed or native binaries were added. - The new doc links go to Discord invites,
github.com/SpaceGT/Pulsar,github.com/sepluginloaderandgithub.com/viktor-ferenczi/se-script-merge. No code uses them.
Behavior
- The Publish button now sits to the right of the vanilla button whose
NameisLoadWorld(main menu) orOptions(in-game menu), and the vanilla buttons no longer move. Checked against the decompiled game:MyGuiScreenMainMenuBase.MakeButtonsetsName, andMyGuiScreenMainMenu.CreateMainMenu/CreateInGameMenucreate"LoadWorld"and"Options"without conditions. If the button is missing,FirstOrDefaultreturns null and the patch adds nothing, which fails safe. Tracker.Updatenow skips the script/PB sync whileConfig.Enabledis false. Before this change the checkbox did nothing. The default istrue, andPlugin.Configis loaded inInitbefore anyUpdateruns.SetColumnWidthsNormalizedexists onMyLayoutTableand scales 120:880 to the table width.
From-source build
dotnet build ClientPlugin/ClientPlugin.csproj -c Release (net10.0, SDK 10.0.400, Linux, game Bin64, deploy off) at 60b98b4: 0 warnings, 0 errors. This is an MSBuild build, not Pulsar's Roslyn source compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScriptDev 1.1.1, pinned to viktor-ferenczi/se-script-dev@60b98b4, the head of main (viktor-ferenczi/se-script-dev#8 merged, plus a README link update).
Tested on Linux (Pulsar Interim, headless 1280x720, Continue Game showing): both menus keep the vanilla layout and the button opens the dialog.