test(e2e): Phase 2 journey coverage - #26
Merged
Merged
Conversation
Six specs, each locking a specific past regression rather than testing a feature in the abstract — the commit that broke it is named in each comment. - view-mode round trip in both directions (fb3a3cb: rawMarkdown and the Tiptap document were independent, so switching mode silently dropped edits) - inserting a block twice in a row (74647b4: an atom node at end-of-document left a NodeSelection, so the next insert replaced it instead of adding — only the first insert of a session ever worked) - inserting from the slash menu, now addressable as a listbox - rapid file switching landing on the file clicked last (B13's load race) - Dataset registering and Query returning rows from it, end to end through DuckDB-WASM Nineteen E2E specs now, all green, each inheriting the console/network gate. The Dataset spec found its own bug on the first run: it queried `role`, a column the demo workspace has and the seeded E2E workspace does not. The app was right and the test was wrong — worth recording, because a test written against the wrong fixture is the kind that gets "fixed" by loosening an assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six specs, each locking a specific past regression rather than testing a feature in the abstract. The commit that broke it is named in each comment.
fb3a3cb— rawMarkdown and the Tiptap doc were independent, so switching mode silently dropped edits74647b4— an atom node at end-of-document left a NodeSelection, so the next insert replaced it. Only the first insert of a session ever worked19 E2E specs now, all green, each inheriting the console/network gate.
The Dataset spec found its own bug on the first run: it queried
role, a column the demo workspace has and the seeded E2E workspace does not. The app was right, the test was wrong — worth recording, because a test written against the wrong fixture is exactly the kind that gets "fixed" by loosening an assertion.🤖 Generated with Claude Code
https://claude.ai/code/session_01TYuTJt2hh7k8mg8FXCKrw1