Skip to content

BP-2422: Sharphound collector setup for cross-trust collection#343

Open
jeff-matthews wants to merge 1 commit into
mainfrom
BP-2422-collector-setup
Open

BP-2422: Sharphound collector setup for cross-trust collection#343
jeff-matthews wants to merge 1 commit into
mainfrom
BP-2422-collector-setup

Conversation

@jeff-matthews

@jeff-matthews jeff-matthews commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Improve SharpHound collector setup based on feedback in BP-2422.

Summary by CodeRabbit

  • Documentation
    • Improved enterprise collection guides with clearer step-by-step instructions and updated screenshots.
    • Added guidance for advanced collection options, including scope across multiple trusted domains.
    • Clarified cross-trust collection setup, authentication behavior, and troubleshooting steps.
    • Refined scan option descriptions and prerequisites for better readability and consistency.

@jeff-matthews jeff-matthews self-assigned this Jul 8, 2026
@jeff-matthews jeff-matthews added feedback Updates based on internal and external feedback data-collection Docs related to nodes, edges, and general data collection labels Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: af85ebf2-afbf-4b0f-b0e5-f0c66ba68de0

📥 Commits

Reviewing files that changed from the base of the PR and between 042edad and 55268a1.

⛔ Files ignored due to path filters (3)
  • docs/images/data_collectors/add-schedule.png is excluded by !**/*.png
  • docs/images/data_collectors/configure-on-demand-scan.png is excluded by !**/*.png
  • docs/images/data_collectors/configure-schedule.png is excluded by !**/*.png
📒 Files selected for processing (5)
  • docs/collect-data/enterprise-collection/collection-schedule.mdx
  • docs/collect-data/enterprise-collection/cross-trust.mdx
  • docs/collect-data/enterprise-collection/on-demand-scan.mdx
  • docs/snippets/hounds/scan-options.mdx
  • docs/snippets/hounds/sharphound-advanced-note.mdx

Walkthrough

This PR updates SharpHound Enterprise documentation across several MDX files. It introduces a new shared SharpHoundAdvancedNote component describing multi-domain scope collection, updates cross-trust and scan-options guidance for trust-based collection semantics, and revises formatting/wording in collection-schedule and on-demand-scan pages.

Changes

SharpHound Enterprise documentation updates

Layer / File(s) Summary
Shared advanced-note component and scan options
docs/snippets/hounds/sharphound-advanced-note.mdx, docs/snippets/hounds/scan-options.mdx
Adds a new <Note> component explaining multi-domain scope collection setup and updates OU targeting and multi-domain trust collection descriptions with expanded wording and list markup.
Collection schedule guide
docs/collect-data/enterprise-collection/collection-schedule.mdx
Reformats intro/prerequisites and <Note> styling, rewords the Edit Client hamburger-menu instruction, adjusts screenshot widths, and inserts the new advanced-options note.
On-demand scan guide
docs/collect-data/enterprise-collection/on-demand-scan.mdx
Adds the SharpHoundAdvancedNote import and usage under Advanced Options, and formats prerequisites as bullet items.
Cross-trust collection guide
docs/collect-data/enterprise-collection/cross-trust.mdx
Renames and restructures cross-trust sections, converts default-scope guidance into a callout, rewrites LDAP auto-negotiation content with a <Tip>, updates hardening link text, and reformats troubleshoot bullets.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: StephenHinck

Poem

A hop through docs both new and old,
Notes about domains, trusts retold,
Menus renamed, screenshots wide,
SharpHound's scope now clarified.
🐰 Thumping paws on markdown ground —
Cleaner guides for hounds to be found!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main documentation update around SharpHound collector setup for cross-trust collection.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BP-2422-collector-setup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jeff-matthews
jeff-matthews requested a review from specterkris July 8, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data-collection Docs related to nodes, edges, and general data collection feedback Updates based on internal and external feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants