feat: get available managment operation endpoint BED-8266#2984
feat: get available managment operation endpoint BED-8266#2984lrfalslev wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughAdds OpenAPI definitions for client management operation types, statuses, lifecycle fields, and a new ChangesClient management availability API
Estimated code review effort: 2 (Simple) | ~15 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/go/openapi/src/paths/clients.clients.management.available.yaml`:
- Around line 19-25: The available-clients endpoint declares client_id as a
required path parameter without a matching path template. In
packages/go/openapi/src/paths/clients.clients.management.available.yaml lines
19-25, determine whether client_id is a query parameter or should be removed
based on the endpoint contract; if it remains a path parameter, update
packages/go/openapi/src/openapi.yaml lines 705-708 to include {client_id} in the
path. Regenerate packages/go/openapi/doc/openapi.json lines 16425-16481 from the
corrected YAML rather than editing it directly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 88c2cc87-f269-444a-852c-114551a56cea
📒 Files selected for processing (6)
packages/go/openapi/doc/openapi.jsonpackages/go/openapi/src/openapi.yamlpackages/go/openapi/src/paths/clients.clients.management.available.yamlpackages/go/openapi/src/schemas/enum.client-management-operation-status.yamlpackages/go/openapi/src/schemas/enum.client-management-operation-type.yamlpackages/go/openapi/src/schemas/model.client-management-operation.yaml
3ed16a0 to
a36eea9
Compare
Description
Adds get available management operation endpoints to openapi schema, for BHE pr 1568
Motivation and Context
Resolves BED-8266
Why is this change required? What problem does it solve?
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Screenshots (optional):
Types of changes
Checklist:
Summary by CodeRabbit
GET /api/v2/clients/management/availableto retrieve the next available client management operations, using thePreferheader (noclient_idpath parameter).200response as JSON containing adataarray of management operation objects.support_bundle) and lifecycle status values (queued,running,succeeded,failed,canceled), including operation identifiers and lifecycle timestamps.401,403,429, and500.