Skip to content

fix(docs): Updates for BED-8602#2967

Open
slimi-so wants to merge 5 commits into
mainfrom
BED-8602-archive-inactive-domain-findings
Open

fix(docs): Updates for BED-8602#2967
slimi-so wants to merge 5 commits into
mainfrom
BED-8602-archive-inactive-domain-findings

Conversation

@slimi-so

@slimi-so slimi-so commented Jul 7, 2026

Copy link
Copy Markdown
Contributor
  • Adds 'orphaned' status to attack-paths.attack-paths-findings.yaml doc Resolves BED-8602

Description

Describe your changes in detail

Motivation and Context

Small API documentation update for /attack-paths/findings endpoint to also get findings by orphaned status

Resolves

Why is this change required? What problem does it solve?
API documentation update for a bug fix in BHE where we add an archive finding status of 'orphaned' for findings associated with an inactive Domain.

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Database Migrations

Checklist:

Summary by CodeRabbit

  • Bug Fixes
    • API responses for attack path findings now recognize an additional orphaned status value.
  • Chores
    • Updated several Go module dependencies to newer releases to support maintenance and compatibility.

slimi-so added 2 commits July 7, 2026 17:31
- Adds 'orphaned' status to attack-paths.attack-paths-findings.yaml doc
Resolves BED-8602
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 5e801bd4-6f44-488e-b430-5834f99bb94d

📥 Commits

Reviewing files that changed from the base of the PR and between a27bf47 and fdcf488.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
✅ Files skipped from review due to trivial changes (1)
  • go.mod

📝 Walkthrough

Walkthrough

This PR updates dependency versions for several golang.org/x and google.golang.org packages in go.mod, and extends the OpenAPI schema for attack path findings by adding an "orphaned" value to the status field enum.

Changes

Dependency Version Updates

Layer / File(s) Summary
Go module bumps
go.mod
Updated versions for golang.org/x/crypto, golang.org/x/mod, golang.org/x/oauth2, golang.org/x/text, golang.org/x/tools, golang.org/x/term, golang.org/x/net, golang.org/x/sync, golang.org/x/sys, golang.org/x/telemetry, google.golang.org/genproto/googleapis/rpc, and google.golang.org/grpc in direct and indirect require blocks.

Attack Path Findings API Schema

Layer / File(s) Summary
Status enum extension
packages/go/openapi/src/paths/attack-paths.attack-paths-findings.yaml
Added orphaned to the allowed enum values for the status field in the 200 response schema.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: api

Suggested reviewers: benwaples, cweidenkeller

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The template is present, but the Description and How Has Been Tested sections are essentially empty. Add a real change summary, complete the testing section, and check the applicable types and checklist items.
Title check ❓ Inconclusive The title is related to the change, but it is too generic to clearly describe the main update. Use a concise, specific title such as 'docs: add orphaned attack-path finding status to OpenAPI'.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BED-8602-archive-inactive-domain-findings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the api A pull request containing changes affecting the API code. label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api A pull request containing changes affecting the API code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant