feat: Optimize PG source_kind, relation deletion using indices - BED-8832#2942
Open
StephenHinck wants to merge 2 commits into
Open
feat: Optimize PG source_kind, relation deletion using indices - BED-8832#2942StephenHinck wants to merge 2 commits into
StephenHinck wants to merge 2 commits into
Conversation
Contributor
📝 WalkthroughWalkthrough
Graph Data Deletion Refactor
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the new DeleteNodesByKinds/DeleteRelationshipsByKinds functions supported optionally on DAWGS drivers to execute rapid deletion of objects by kind. Initially, this is supported on PostgreSQL drivers.
Requires SpecterOps/DAWGS#101
Note: this was run with the expectation that SpecterOps/DAWGS#100 has already merged. The timings for source_kind deletion include this change.
Motivation and Context
Resolves BED-8832
Why is this change required? What problem does it solve?
How Has This Been Tested?
Validated locally and confirmed existing tests continue to pass.
Screenshots (optional):
Tested using large OGGen payloads for validation:
Delete by source_kind:
Before:
After:
Delete by relationship:
Before:
After:
Types of changes
Checklist:
Summary by CodeRabbit