Implement Multiple Source CFL reachability algorithm, add a draft of optimized version. - #6

Draft

spisladqo wants to merge 228 commits into

multsrc_cfl_opts_a

Commits on Oct 16, 2025

Feat: intial commit with draft version of CFL algorithm with
homka122
committed
ade1e99
Feat: add algorithm with optimization to header
homka122
committed
8b16e59
Feat: add measure time macro
homka122
committed
2cdcee7
Feat: add null check to mxm
homka122
committed
9548c1e
Refactor: replace apply to ewiseAdd
homka122
committed
4660261
Feat: replace apply to dup method
homka122
committed
6bd45f2
Fix: type in printf while iteration
homka122
committed
76bc80a
Refactor: apply mask now seperate function
homka122
committed
4115a05
Refactor: now bench information output only with flag
homka122
committed
838ad5b
Feat: add ISO check to rsub
homka122
committed
7d113dd
Refactor: iteration info now print if flag set
homka122
committed
0433361
Feat: add null check in first mxm
homka122
committed
155e609
Feat: now empty optimization is seperate
homka122
committed
8dc7d1d
Feat: add rsub, wise and dup with format optimization
homka122
committed
08ab76c
Feat: add mxm format optimization
homka122
committed
4668c88
Refactor: delete unused comments
homka122
committed
45aaf82
Fix: change NULL to GrB_NULL
homka122
committed
fe16527
Fix: change dup method according to format optimization
homka122
committed
b198dd3
Feat: add clear methods with optimization
homka122
committed
54ba2b8
Feat: add change format methods
homka122
committed
9c7c923
Feat: process result of matrix_mxm
homka122
committed
067fb3a
Fix: now all methods in empty wise use format methods
homka122
committed
ba335af
Refactor: change rsub method with format optim
homka122
committed
8877469
Refactor: change wise method with format optimization
homka122
committed
a5b9f0e
Fix: fix wrong type in for cycle
homka122
committed
0a59d20
Fix: change GrB clear method to mine
homka122
committed
0bc599f
Feat: add rmxm method
homka122
committed
135ba92
Fix: incompitible type of for cycle
homka122
committed
e85a7c1
Refactor: delete unused variables
homka122
committed
e95dbad
Feat: delete unused sync format method
homka122
committed
3756ed9
Feat: use more optimize methods in wise method
homka122
committed
539260d
Feat: manually choose format in wise and dup method
homka122
committed
007c6b7
Fix: wrong type in for cycle
homka122
committed
36ffc72
Feat: now update Matrix object in place
homka122
committed
a180624
Feat: delete seperate rmxm method
homka122
committed
cf89d6a
Refactor: matrix mxm with swap operation
homka122
committed
901323d
Feat: add lazy optimization
homka122
committed
61f90aa
Fix: change < to <=
homka122
committed
fd2502e
Feat: use lazy optimization
homka122
committed
7b0a5e1
Feat: add flags for turn on optimizations on runtime
homka122
committed
935baef
Feat: matrix_print_lazy now accepts pointer
homka122
committed
aa0dd4a
Feat: add naming for matrices in methods
homka122
committed
7184953
Feat: lazy optimizations now works
homka122
committed
66d55a8
Fix: erase matrix when accum true in mxm
homka122
committed
6d97d82
Feat: add sort and combine function to lazy optimization
homka122
committed
146d58c
Fix: some memory leaks
homka122
committed
bd2c142
Feat: now matrix has not just mxm size
homka122
committed
c0eae50
Feat: Add fields to Matrix object for block matrices
homka122
committed
bc0af0d
Feat: change rule parsing
homka122
committed
eb313af
Feat: implement block mxm operation
homka122
committed
9be8a15
Fix: first mxm need accum operator for correct result
homka122
committed
cc23b24
Feat: implement wise block operation
homka122
committed
e6a77bf
Feat: add create and free methods for Matrix structure
homka122
committed
8249fc1
Feat: implement rsub block operation
homka122
committed
6225f49
Feat: add block hyper rotate method
homka122
committed
3595a8f
Feat: add block matrix to diag method
homka122
committed
c0adbab
Feat: add block matrix reduce method
homka122
committed
caddbf1
Fix: wrong type input
homka122
committed
b7e68b8
Feat: add method matrix -> block vector
homka122
committed
3359d61
Fix: fix bug when dublicate adj matrices
homka122
committed
c79861f
Fix: compiler warnings
homka122
committed
5f96e31
Fix: copy graph matrix from ajd
homka122
committed
6b25fa4
Feat: add block optimization choice
homka122
committed
c030cca
Feat: now implicitly declare that graph matrices are lazy
homka122
committed
3aea853
Fix: is lazy check in rsub function
homka122
committed
68301f9
Fix: update base matrix nnz before calc in lazy matrix
homka122
committed
d734683
Refactor: algorithm now accepth symbol count
homka122
committed
7c17e47
Feat: sort matrices before find acc
homka122
committed
8440287
Feat: new way checking changing graph
homka122
committed
9cf80c2
Refactor: make more useful matrix printing
homka122
committed
b99cc1b
Feat: add simple rules adding to matrices
homka122
committed
ee4ffa4
Refactor: move custom methods definition
homka122
committed
e166fc1
Feat: now delta matrices dublicates from adj matrices
homka122
committed
5b73708
Refactor: rework print lazy method
homka122
committed
5502c89
Fix: check is lazy status in mxm lazy method
homka122
committed
6ce43b0
Feat: add iadd interpration to wise methods
homka122
committed
b0d3f53
Fix: problems with sorting in mxm lazy
homka122
committed
5100773
Fix: update matrix after combine base matrices
homka122
committed
2e63e5f
Refactor: now use TRY macro
homka122
committed
08a19c9
Fix: return from block mxm is both matrices are cell
homka122
committed
df5cdea
Fix: use lazy matrices with lazy optimization and higher
homka122
committed
8a1b404
Fix: wise_block
homka122
committed
88f25bd
Fix: forget update matrix after changing
homka122
committed
c05d6c0
Fix: now if symbol is indexed matrix is block
homka122
committed
e0841c0
Feat: add print_graph_info function
homka122
committed
61ada93
Fix: add method for dup block matrices
homka122
committed
22e4c4c
Fix: bug that lazy matrix didn't create
homka122
committed
8c85e4e
Fix: matrix mxm now can multiply not only square matrices
homka122
committed
6b59c0f
Feat: create temp matrix in mxm block
homka122
committed
46608e1
Refactor: matrix dup now uses a different method
homka122
committed
513aeca
Fix: hyper rotate method
homka122
committed
f49a6b2
Feat: add aditional check in matrix update
homka122
committed
697d23c
Fix: assert condition in rsub block
homka122
committed
6865893
Feat: check result of rsub methods
homka122
committed
3bf3ba4
Fix: fix order of flags
homka122
committed
595a2cb
Refactor: delete unused T matrix from prev algo
homka122
committed
af498f8
Refactor: delete whitespaces after if statement
homka122
committed
2b8337b
Feat: move functions with optimized matrices in seperate file
homka122
committed
8f57591
Refactor: move optimizations methods to seperate file
homka122
committed
b87cead
Refactor: delete unused code and fix types of structures
homka122
committed
2334b27
test: add tests for adv algorithm
homka122
committed
c7ba5c0
Fix: delete files with algorithm
homka122
committed
9941af1

Commits on Oct 17, 2025

Fix: delete unused files
homka122
committed
28c6696

Commits on Oct 31, 2025

fix: update nvals before reading it
spisladqo
committed
94aecfb

Commits on Nov 3, 2025

test: add tests for optimized matrix
homka122
committed
89756bf
Test: add tests for matrix_opt: wise, rsub, format optimization
homka122
committed
aa2d64a
Test: add tests for matrix_opt: empty optimization
homka122
committed
ae1daff
Refactor: now matrix_to_base don't modify input matrix
homka122
committed
39bf9da
Feat: add dup_lazy
homka122
committed
9608e2b
Fix: delete unused sort of matrices
homka122
committed
f1b4a5c
Fix: delete unreacheable block of code in rsub
homka122
committed
098bc8c
Test: add tests for lazy optimization
homka122
committed
a6e0148

Commits on Nov 4, 2025

Commits on Nov 8, 2025

copy LAGraph_CFL_reachability.c as a template
spisladqo
committed
e76f729
add initialization of src matrices and error checks, update doc
spisladqo
committed
7b84b14
add initialization for vertices' terminals rules
spisladqo
committed
8bc5a3b
add final steps of algorithm, remove extra steps
spisladqo
committed
cd3ca6c
add CFL_reachability_multsrc to header
spisladqo
committed
0f96e3a
add tests structure for CFL_reachabiliy_multsrc
spisladqo
committed
9cc8cb7
copy tests for all-sources CFL reachability
spisladqo
committed
1450390
fix bugs with continue in loop, add debug prints
spisladqo
committed
955419e
fix bug with src vertices in test
spisladqo
committed
cc91c19
fix some memory leaks
spisladqo
committed
f840dc4
fix incorrect check for if matrices were changed
spisladqo
committed
d3db708
remove unneeded check that was made earlier
spisladqo
committed
f509bc4
add more tests
spisladqo
committed
63d6243
fix return on invalid parameters and add more tests, 100% cov
spisladqo
committed
eca0c90
update (c) 2024 -> 2025 in doc-comments
spisladqo
committed
7312361
add copy of multsrc CFL to add optimizations to
spisladqo
committed
5529fe5
put matrix initialization out of loop
spisladqo
committed
b547d5a
add draft of incremental optimization
spisladqo
committed
574a0fb
add step 2 for 1st optimization
spisladqo
committed
2b78acd
add fast algo to LAGraphX.h
spisladqo
committed
81dd68c
add step 3 for 1st optimization
spisladqo
committed
16dc8f2
remove matrix M
spisladqo
committed
3d73fe6
add optimizations mask to algo interface
spisladqo
committed
cf6de8c
use Homka122's CFL_Matrix in multsrc fast algo
spisladqo
committed
6db6bb0
change all operations to specific CFL-optimized ones
spisladqo
committed
162ff34
fix tests, they compare output matrix directly now
spisladqo
committed
580ff00
fix creation of dT matrices, add CFL_optimized things in header
spisladqo
committed
2cb0d7e
fix: matrix_to_format when matrix contains both formats
spisladqo
committed
4ea49bc
feat: make more readable error msg in multsrc tests, add free(result_str)
spisladqo
committed
2f79741
fix: add CFL_matrix_to_base
spisladqo
committed
3d879a8
fix: don't work on base matrices directly, delete outdated comments
spisladqo
committed
3b79c1c
feat: instead of working with T, work with dT
spisladqo
committed
4502cca
fix: update T and dT side-by-side
spisladqo
committed
c6873de
refactor: delete unused variables and comments
spisladqo
committed
117ca9c

Commits on Nov 10, 2025

fix: add missing free
spisladqo
committed
9098b43

Commits on Nov 19, 2025

feat: 100% cov
spisladqo
committed
5fde186
feat: little optimization of multsrc reachability, remove walls of comments
spisladqo
committed
cda9498

Commits on Sep 6, 2026

Feat: change API with opt methods

homka122
authored and
spisladqo
committed
b52f3e2
Fix: algorithm change input adj_matrices

homka122
authored and
spisladqo
committed
9e4c4bb
Refactor: apply clang-format to code

homka122
authored and
spisladqo
committed
aafa0da
Fix: change matrix_to_base function

homka122
authored and
spisladqo
committed
3859ee8
Fix: add adv algorithm signature to LAGraphX.h

homka122
authored and
spisladqo
committed
8de28d0
Test: add tests for adv CFL reachability algorithm

homka122
authored and
spisladqo
committed
f2edc70
Feature: add LAGraph_rule_EWCNF

homka122
authored and
spisladqo
committed
d506548
Feat: now adv algorithm can process EWCNF rules

homka122
authored and
spisladqo
committed
9667bc0
Fix: fix adv algo tests with EWCNF rules

homka122
authored and
spisladqo
committed
4ddb060
Feat: add to print_matrix utility func optimization flag

homka122
authored and
spisladqo
committed
743d40e
Fix: fix memory leaks in adv algorithm

homka122
authored and
spisladqo
committed
319139c
Fix: fix memory leak with symbols

homka122
authored and
spisladqo
committed
dda6cbd
Fix: fix dimension dismatch to output part of algorithm

homka122
authored and
spisladqo
committed
2abf7a4
Fix: rewrite opt operaions for memory leaks fix

homka122
authored and
spisladqo
committed
8f195c1
Fix: bug with unupdate matrix

homka122
authored and
spisladqo
committed
975e01e
Feat: add TRY_I macros

homka122
authored and
spisladqo
committed
0cc48ba
Feat: add BENCH_CFL_REACHBILITY macro for debug purpose

homka122
authored and
spisladqo
committed
98d40cd
Refactor: now use TRY macro for every GrB\LG call

homka122
authored and
spisladqo
committed
f435774
Refactor: change calls to opt methods because of changing API

homka122
authored and
spisladqo
committed
4aea124
Test: add new grammars for indexed rules

homka122
authored and
spisladqo
committed
523af1a
Test: add two new graphs for tests

homka122
authored and
spisladqo
committed
310c59f
Test: add new indexed tests for adv CFL algo

homka122
authored and
spisladqo
committed
3494e30
Fix: fix matrix_update call with new API

homka122
authored and
spisladqo
committed
ee66d39
Fix: fix wrong free symbols in LG_FREE_WORK

homka122
authored and
spisladqo
committed
b0170d0
Test: fix memory leaks and heap overflow in tests

homka122
authored and
spisladqo
committed
db9e27d
Refactor: delete unuserd debug prints

homka122
authored and
spisladqo
committed
4f30db8
Refactor: use new CFL_create functions

homka122
authored and
spisladqo
committed
907388d
Refactor: simplify getting outputs matrices

homka122
authored and
spisladqo
committed
f16c7f2
Refactor: add documentations of inner functions in adv CFL algo

homka122
authored and
spisladqo
committed
8de3218
Refactor: add TRY_INNER macro for helper functions

homka122
authored and
spisladqo
committed
f4b64fa
Feat: add CFL matrix split method

homka122
authored and
spisladqo
committed
c031b51
Docs: adjust description of adv CFL reachability algorithm

homka122
authored and
spisladqo
committed
c9f5672
Fix: change initial capacity for dynamic arrays

homka122
authored and
spisladqo
committed
364ecdb
Test: add new indexed test

homka122
authored and
spisladqo
committed
92d4878
Fix: revert CMakeLists.txt changes

homka122
authored and
spisladqo
committed
8601242
Refactor: now making new symbols is seperate function

homka122
authored and
spisladqo
committed
7ca2e72
Refactor: now making new adj matrices in seperate function

homka122
authored and
spisladqo
committed
35ad275
Refactor: now making new rules in seperate function

homka122
authored and
spisladqo
committed
aac06a6
Refactor: move CFL methods to seperate header file

homka122
authored and
spisladqo
committed
9573504
Refactor: fix TODO in matrix opt methods

homka122
authored and
spisladqo
committed
cc4f1d4
Refactor: refactor LG_FREE_ALL macro in adv CFL algo

homka122
authored and
spisladqo
committed
bc3db8a
Refactor: comment unused code in matrix opt

homka122
authored and
spisladqo
committed
4b3d096
Tests: add tests for block format hyper rotate

homka122
authored and
spisladqo
committed
5f55316
Tests: fix test and add new for adv algo

homka122
authored and
spisladqo
committed
5a3d8a2
add CFL_reachability_multsrc to header
spisladqo
committed
598e947
feat: use updated interface of optimized cfl
spisladqo
committed
66d96d8
fix: update required format in matrix_to_format
spisladqo
committed
5d94fd3
docs: update year in multsrc cfl algos and tests
spisladqo
committed
fb82a98
ref: rename multsrc_fast into multsrc_adv
spisladqo
committed
06f8dfc
fix: matrix_mxm_lazy when first is lazy
spisladqo
committed
2d00f7c
fix: only T[i] are created lazy now
spisladqo
committed
9a94a42
test: add separate test file for multsrc_adv algo
spisladqo
committed
9104c8a
test: update multsrc_adv tests to run under multiple optmasks
spisladqo
committed
21d8956
fix: order in test results doesn't matter now
spisladqo
committed
67cc774
feat: now multsrc_adv can use block optimization, and updated interface
spisladqo
committed
6df0c73
test: updated tests for new interface
spisladqo
committed
a16609e
ref: got rid of Adj opt matrices
spisladqo
committed
3d4ef6e
fix: change MAX_MASK in ms adv tests to 15=0b1111
spisladqo
committed
75ce8e7
ref: delete useless commented code in ms adv
spisladqo
committed
d97c67b
ref: make masks in ms adv tests more clear
spisladqo
committed
1ae56e7
ref: delete useless comments in both ms algos
spisladqo
committed
68c1a9d
feat: revisit multsrc_adv
spisladqo
committed
641f748
feat: remove useless steps
spisladqo
committed
e4ebb0d
feat: rename dT and remove extra step
spisladqo
committed
ae308ed
feat: add export commented out
spisladqo
committed
18d11ed
fix: memory leaks
spisladqo
committed
a6547c2
feat: add time tracking
spisladqo
committed
d9e6441
fix: docs comment for adv algo
spisladqo
committed
c39de05
feat: add handy time counting macro, delete dead comms
spisladqo
committed
9b6c205
ref: add LG_ASSERT_MSG, tidy up code
spisladqo
committed
5a3ecb7
docs: add more comment docs
spisladqo
committed
36546d8
fix: header and unused variable
spisladqo
committed
6280438
docs: update functions doc-comments
spisladqo
committed
b4d164f

Commits on Sep 9, 2026

fix: revert lg_assert_msg
spisladqo
committed
1f70699