fix: silent crash when openvrpaths file has invalid json data#3
Open
SpaceFox1 wants to merge 1 commit into
Open
fix: silent crash when openvrpaths file has invalid json data#3SpaceFox1 wants to merge 1 commit into
SpaceFox1 wants to merge 1 commit into
Conversation
Co-authored-by: kitsuvm <50382775+kitsuvm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When launching any game with proton, be it a VR title or not, proton will check for the openvrpaths file, and if it exists it will try and parse its contents, however if the file contains invalid json data this causes proton to throw and since the exception is unhandled proton just crashes silently, causing the user to wonder why any of their proton steam games are launching