Repository navigation
Conversation
…racts handleClearContracts called readAllRecent() after writeRecent([]), which always returns []. Use new Set() directly to avoid an unnecessary localStorage read. Closes Sorokit#717
|
@JinadJay Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
CI environment has @types/node conflicting with DOM types for setInterval return type. Explicitly annotate timerId to resolve. Closes Sorokit#717
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #717 reports that
SorobanScreen.tsxreadslocalStorageon every re-render via inlinelocalStorage.getItem()calls. The core fix (useStatelazy init forsavedContractsBase) was already onmain. However,handleClearContractsstill calledreadAllRecent()(alocalStorage.getItemwrapper) redundantly afterwriteRecent([]), which always returns[].Solution
new Set(readAllRecent())withnew Set()inhandleClearContracts— after clearing localStorage, there's no need to re-read it.useState(() => readAllRecent())lazy init at line 63 ensures localStorage is only read on mount.reads localStorage.getItem exactly once on mount, not on subsequent re-renders (#815)) already verifies the core fix.Acceptance Criteria
localStorage.getItemis not called on every render (lazyuseStateinit)setSavedContractsBase)setSavedContractsBase)SorobanScreen.test.tsxverifies reactive list updates (existing test at line 179)Closes #717