Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The requested multi-monitor initialization fixes are fully addressed with no unresolved review comments.
Review effort: Lite
Findings: None
What changed in this PR
Fixes Windows startup handling in multi-monitor environments by enumerating all fallback monitors and selecting a valid target when no primary monitor is found.
Changes:
- Removes the premature fallback enumeration break.
- Adds safe monitor selection for window creation.
| File | Description |
|---|---|
Siv3D/src/Siv3D-Platform/WindowsDesktop/Siv3D/Window/CWindow.cpp |
Adds fallback monitor selection during window initialization. |
Siv3D/src/Siv3D-Platform/WindowsDesktop/Siv3D/Monitor/SivMonitor_Windows.cpp |
Enumerates all fallback monitors. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue1342 に対する修正