Add Monorail telemetry for app config validate#7120
Add Monorail telemetry for app config validate#7120dmerand wants to merge 3 commits intodlm-app-validate-malformed-extension-configsfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/monorail.d.ts@@ -66,6 +66,10 @@ export interface Schemas {
cmd_app_linked_config_uses_cli_managed_urls?: Optional<boolean>;
cmd_app_warning_api_key_deprecation_displayed?: Optional<boolean>;
cmd_app_deployment_mode?: Optional<string>;
+ cmd_app_validate_json?: Optional<boolean>;
+ cmd_app_validate_valid?: Optional<boolean>;
+ cmd_app_validate_issue_count?: Optional<number>;
+ cmd_app_validate_file_count?: Optional<number>;
cmd_dev_tunnel_type?: Optional<string>;
cmd_dev_tunnel_custom_hash?: Optional<string>;
cmd_dev_urls_updated?: Optional<boolean>;
|
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Coverage report
Test suite run success4016 tests passing in 1530 suites. Report generated by 🧪jest coverage report action from 92db345 |

What
Add Monorail instrumentation for
shopify app config validate.This records whether
--jsonwas used and captures aggregate validate results: whether the run was valid, how many issues were found, and how many files those issues came from.WHAT is this pull request doing?
cmd_app_validate_jsoncmd_app_validate_validcmd_app_validate_issue_countcmd_app_validate_file_countLocalConfigErrorfailures that happen beforevalidateApprunsSHOPIFY_*environment variables without adding new first-class Monorail schema fields yetWhy
We want to measure how
app config validateis being used and what kinds of results it produces.That gives us a way to track JSON usage and validate outcomes while the current validate work rolls out, without introducing a broader telemetry model for agent identity yet.
How
The command records
cmd_app_validate_jsonat entry.The validate flow records aggregate outcome metadata from canonical validation issues so the counts stay aligned with real validation failures instead of display-only wrapper messages.
Testing
To test manually:
shopify app config validateshopify app config validate --jsonPost-release steps
None.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist