optimize asset checksum filtering with Set lookup#7105
Draft
EvilGenius13 wants to merge 1 commit intomainfrom
Draft
optimize asset checksum filtering with Set lookup#7105EvilGenius13 wants to merge 1 commit intomainfrom
EvilGenius13 wants to merge 1 commit intomainfrom
Conversation
Replace O(n) Array.some() scan with O(1) Set lookup by pre-computing liquid asset keys. Reduces complexity from O(n²) to O(n) for themes with many assets.
EvilGenius13
changed the title
Contributor
Coverage report
Test suite run success3970 tests passing in 1524 suites. Report generated by 🧪jest coverage report action from 268291c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We can improve performance around asset checksums.
WHAT is this pull request doing?
Optimizes
rejectGeneratedStaticAssetsin asset-checksum.ts from O(n²) to O(n) by pre-computing a Set of liquid asset keys.Before: For each asset,
hasLiquidSource()scans the entire array withsome()— O(n) per asset, O(n²) total.After: Pre-compute a Set of liquid asset keys once, then use O(1)
has()lookups.How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist