Add install count warning for safer deploys#7087
Open
alfonso-noriega wants to merge 1 commit intomainfrom
Open
Add install count warning for safer deploys#7087alfonso-noriega wants to merge 1 commit intomainfrom
alfonso-noriega wants to merge 1 commit intomainfrom
Conversation
8257ac9 to
40cf609
Compare
Contributor
Coverage report
Test suite run success3933 tests passing in 1514 suites. Report generated by 🧪jest coverage report action from 0a8f305 |
40cf609 to
446e18a
Compare
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
dmerand
reviewed
Mar 25, 2026
Contributor
dmerand
left a comment
There was a problem hiding this comment.
Found a few things worth considering
446e18a to
0a8f305
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🚨 NOTE: Do not merge before PR#532386 is deployed 🚨
What
Surfaces the number of affected app installations in the
app deploy/app releaseconfirmation prompt when a release removes extensions. This gives developers a clear picture of the blast radius before they confirm a destructive operation.Closes https://github.com/shop/issues-develop/issues/22421
How
New GraphQL query (
app-install-count.graphql) — queriesinstallCounton theApptype, exposed by the Management API in shop/world#532386.New
appInstallCount()method onDeveloperPlatformClient+AppManagementClientimplementation.PartnersClientstubs it as unsupported.Fetched lazily in
ensureDeploymentIdsPresence()— only when the extension breakdown contains removals (onlyRemote.length > 0), right before the confirmation prompt. Wrapped in try/catch so a failure never blocks the deploy.Warning rendered in
deploy-release.ts— added to the dangerous confirmation prompt (the one requiring the user to type the app name) whenhasDeletedExtensions && installCount > 0.Behaviour unchanged in these paths
--no-interactive/ piped input) — prompt is skipped entirely--force/--allow-deletes— prompt is skipped entirely