Repository navigation
fix(deps): stop shipping rollup binary to consumers; harden CI, release and dependencies - #157
Merged
Merged
Conversation
…y tokens - add .DS_Store to .gitignore - remove .yarnrc.yml, which only pointed at a Yarn release removed in the Bun migration - switch CONTRIBUTING dev commands from Yarn to Bun - README: never trust the mock tokens/keys outside tests
The Linux rollup native binary is only needed to build this package in CI, but as an optionalDependency it was part of the published manifest and got installed by every consumer on linux-x64. Move it to devDependencies so the published dependency tree is just jsonwebtoken.
- dependabot: cooldown.default-days 7 for the bun and github-actions ecosystems (version updates only; security updates are not delayed) - bunfig: [install] minimumReleaseAge = 604800 (seconds) so local bun install/update only resolve versions at least 7 days old. Dependabot does not read bunfig, hence both settings.
- packageManager: bun@1.2.2 -> bun@1.4.4 (latest stable, 2026-10-22) - regenerate bun.lock from scratch: the lockfile carried over from the Yarn migration had 448/736 entries without an integrity hash, which bun never verifies; all 670 entries now have sha512 integrity. The fresh resolve also records every rollup native binary instead of only darwin-arm64 - tsup ^8.5.1 -> ^9.0.0 (esbuild ^0.28.2, fixes GHSA-g7r4-m6w7-qqqr); emitted JS is byte-identical, .d.ts only reformatted - override safe-buffer ^5.2.1 so the fresh dedupe does not downgrade jws/jwa/ecdsa-sig-formatter to safe-buffer 5.1.2 bun audit: 111 -> 1 advisory. Remaining: braces@3.0.3 (GHSA-vfj7-8cjw-p6xm, high) via micromatch in semantic-release tooling; no patched version is published. Production tree: 0.
- release.yaml now triggers on push to main (and workflow_dispatch), calls ci.yaml as a reusable workflow and only releases via needs: ci. This replaces the workflow_run trigger, whose branches: [main] filter also matches fork PRs from a branch named main - release job runs in the "release" environment so deployment branch rules can restrict publishing to main - CI no longer runs on push itself (release.yaml runs it), keeps pull_request and workflow_dispatch; only PR runs cancel in progress - drop actions: write from CI; workflows default to contents: read - actions/checkout persist-credentials: false in CI; the release job keeps credentials because semantic-release pushes the release commit and tag - setup-bun reads the Bun version from package.json packageManager - bun install --frozen-lockfile everywhere; bun audit --prod in CI - drop setup-node from the release job: bun publish cannot do OIDC trusted publishing/provenance yet, so @semantic-release/npm keeps using the npm CLI pinned in bun.lock (11.21.1) on the runner's Node - pin checkout v7.0.1, setup-bun v2.2.0 and codecov-action v7.1.1 to full commit SHAs with version comments for Dependabot
Reference actions by exact release tag and pin them, including the transitive actions/github-script used by codecov-action, in .github/workflows/actions.lock, generated with gh actions-lock v0.3.0 (GitHub Actions workflow lockfiles, public preview). Dependabot regenerates the lockfile entry when it bumps an action. CI verifies the lockfile with gh actions-lock --verify.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
===========================================
+ Coverage 99.65% 100.00% +0.34%
===========================================
Files 15 15
Lines 291 278 -13
===========================================
- Hits 290 278 -12
+ Misses 1 0 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bun.lock now records rollup's own platform binaries, so the explicit @rollup/rollup-linux-x64-gnu pin is no longer needed.
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 23, 2026
## [1.3.5](v1.3.4...v1.3.5) (2026-10-23) ### Bug Fixes * **deps:** stop shipping rollup binary to consumers; harden CI, release and dependencies ([#157](#157)) ([1b4bca4](1b4bca4))
|
🎉 This PR is included in version 1.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the 2026-10-23 security review (at v1.3.4).
packageManagerbun@1.2.2 → bun@1.4.4; setup-bun reads it viabun-version-file: package.jsonin CI and releasebun publishcannot do OIDC trusted publishing or provenance yet (Bun 1.4.4 docs; oven-sh/bun#15601, #22423), so@semantic-release/npmstill publishes with the npm CLI pinned in bun.lock (11.21.1) on the runner's Node 22. The old setup-node warning came from.yarnrc.ymlpointing at a deleted Yarn releasebun audit: 111 → 1. tsup 9 (esbuild ^0.28.2); fresh resolve;safe-bufferoverride keeps jws/jwa on 5.2.1. Remaining:braces@3.0.3(GHSA-vfj7-8cjw-p6xm, dev-only via semantic-release/micromatch), no patched version published. Production tree: 0 advisories; CI now runsbun audit --prodbun install --frozen-lockfilein every job.github/workflows/actions.lock(GitHub workflow lockfiles, public preview), verified in CI withgh actions-lock --verify@rollup/rollup-linux-x64-gnumoved to devDependencies; packed manifest only depends onjsonwebtokenpushto main, calls CI (workflow_call) and releases vianeeds: ciin thereleaseenvironment;workflow_runremovedactions: writeremoved from CIcooldown.default-days: 7(bun, github-actions); bunfig[install] minimumReleaseAge = 604800persist-credentials: falsein CI; the release job keeps credentials because semantic-release pushes the release commit and tag.DS_Storeignored, stale.yarnrc.ymlremoved, CONTRIBUTING uses Bun, README warns that the mock tokens are for tests only