Pre-1.0 polish: fix live-test order_id length, doc slip, dist hygiene - #9
Merged
Conversation
Findings from a full pre-release review:
- LiveClientTest generated a 22-char order_id ('sdk-probe-' + 12 hex), but
Quickpay enforces 4-20 chars, so the test would fail with a
ValidationException when run with QUICKPAY_LIVE=1. Shorten to 'probe-' +
12 hex = 18 chars.
- Callback's docblock referenced the nonexistent
CallbackHandler::handleRequest(); the method is handleRaw().
- export-ignore CLAUDE.md, /examples and /.env.local.example so dist
installs ship only LICENSE, composer.json and src/ (verified with
git archive --worktree-attributes).
- Drop the extensions: "${{ env.PHP_EXTENSIONS }}" input from all six CI
jobs - the env var was never defined, so it always resolved to an empty
string.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #9 +/- ##
=========================================
Coverage 98.50% 98.50%
Complexity 147 147
=========================================
Files 24 24
Lines 401 401
=========================================
Hits 395 395
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small fixes from a full pre-release review of the library (architecture / tests / docs), clearing the last blockers flagged before tagging
v1.0.0:tests/Client/LiveClientTest.php— the live test generated a 22-characterorder_id('sdk-probe-'+ 12 hex chars), but Quickpay enforces a 4–20 character limit (live-verified, per theCreatePaymentRequestdocblock). The test would have failed with aValidationExceptionon the nextQUICKPAY_LIVE=1run; it never surfaced because live tests are not run in CI. Now'probe-'+ 12 hex = 18 chars, with a comment pinning the constraint.src/Callback/Callback.php— the class docblock referencedCallbackHandler::handleRequest(), which does not exist; the method ishandleRaw()..gitattributes—export-ignoreforCLAUDE.md,/examplesand/.env.local.example, so dist installs no longer ship the AI-instructions file and the whole e2e harness (Dockerfile included). Verified withgit archive --worktree-attributes: the archive now contains onlyLICENSE,composer.jsonandsrc/..github/workflows/build.yaml— removedextensions: "${{ env.PHP_EXTENSIONS }}"from all six jobs; the env var was never defined anywhere, so the input always resolved to an empty string.Test plan
vendor/bin/phpunit— 109 tests green (2 skipped = live-gated)vendor/bin/phpstan analyse— level max, no errorsvendor/bin/ecs check— cleangit archive --worktree-attributes HEAD | tar -t— dist contains onlyLICENSE,composer.json,src/