Declare ext-ctype and ext-filter - #68
Merged
Merged
Conversation
Details::paymentId() (#60) uses ctype_digit() and the factory's boolean normalizer (#61) uses filter_var(), and shipmonk's dependency analyser rightly flags ext-ctype and ext-filter as undeclared shadow dependencies — the Dependency Analysis CI job has been red on 2.x since #60 merged. Both extensions are enabled by default but can be compiled out, so they belong in composer.json alongside the ext-hash / ext-json declarations that already follow the same rule.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #68 +/- ##
=========================================
Coverage 96.93% 96.93%
Complexity 144 144
=========================================
Files 15 15
Lines 392 392
=========================================
Hits 380 380
Misses 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Dependency Analysis CI job, red on
2.xsince #60 merged.Details::paymentId()(#60) usesctype_digit()and the factory's boolean normalizer (#61) usesfilter_var(); shipmonk's analyser correctly flagsext-ctypeandext-filteras undeclared shadow dependencies. Both extensions are enabled by default but can be compiled out, so they belong incomposer.jsonnext to the existingext-hash/ext-jsondeclarations that follow the same rule.This is also why the same job is red on #64, #66 and #67 — they inherit it from
2.x. Merging this (and updating those branches) turns them green.Reproduced locally with
vendor/bin/composer-dependency-analyserbefore the fix;composer all,composer validate --strictandcomposer normalize --dry-runare all clean after it. Follow-up to #57.