Document the flow, the callback reality, Sylius wiring and scope - #66
Open
loevgaard wants to merge 1 commit into
Open
Document the flow, the callback reality, Sylius wiring and scope#66loevgaard wants to merge 1 commit into
loevgaard wants to merge 1 commit into
Conversation
The README's Usage example executed Capture against a fresh model — exactly what does not work: Capture here is a pure money operation, and against an unauthorized payment it fails with a ValidationException rather than opening the payment window. The new flow section says plainly that Authorize is the interactive entry point, shows the authorize-token pattern, and explains what Capture/Refund/Cancel are. Also added, because every new consumer needs them and they only lived in the upgrade guide or nowhere: - the two-callback-url reality (operation callbacks go to the account-wide url, which is empty by default — so they are silently not delivered) and the shipped HeaderAwareGetHttpRequestAction for plain-PHP setups; - a Sylius section: factory registration, stored config keys and use_authorize: true, since Sylius drives checkout through Capture by default; - a scope statement: hosted payment window only, no card-data authorize, subscriptions or payouts.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/header-aware-get-http-request #66 +/- ##
=====================================================================
Coverage 95.46% 95.46%
Complexity 138 138
=====================================================================
Files 15 15
Lines 375 375
=====================================================================
Hits 358 358
Misses 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gaps G1, G3, G4 and G5 of #57. Stacked on #64 (it documents the
HeaderAwareGetHttpRequestActionthat PR ships) — merge that first; this PR's own diff is the last commit.What changed
Captureagainst a fresh model — exactly what does not work here:Captureis a pure money operation, and against an unauthorized payment it yields a QuickpayValidationExceptioninstead of the payment window. The new section states thatAuthorizeis the interactive entry point (unlike gateways whereCapturedrives the whole flow), shows the authorize-token pattern, and describes whatCapture/Refund/Cancelactually do.synchronized/polling alternatives and the plain-PHP header-aware action registration.payum.gateway_factory_builder, where the stored config keys come from, anduse_authorize: true— Sylius drives its checkout throughCaptureby default, which is the wrong entry point for this gateway.Docs only — no code changes.