Update/1.53.0 - #18
Merged
Merged
Conversation
cmd: yarn backstage-cli versions:bump --pattern '@{backstage,backstage-community,roadiehq}/*' --release 1.53.2
componentill broken though
There was a problem hiding this comment.
🟡 Changes recommended
clientIdMetadataDocuments is configured at the wrong config path (root instead of under auth), so the intended setting is likely ignored.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR upgrades the Backstage app baseline (Backstage release + Yarn Backstage plugin) and updates the app/backend to align with the newer release by adding the user settings backend plugin and adjusting frontend navigation/testing.
Changes:
- Bump Backstage version and Yarn Backstage plugin references to
1.53.2. - Add user settings support (backend plugin + app dependency) and adjust sidebar navigation (avoid duplicate notifications item).
- Update E2E selector to target the labeled sidebar navigation region.
File summaries
| File | Description |
|---|---|
| src/packages/backend/src/index.ts | Registers the user settings backend plugin in the backend feature set. |
| src/packages/backend/package.json | Adds @backstage/plugin-user-settings-backend dependency. |
| src/packages/app/src/modules/nav/Sidebar.tsx | Removes the default notifications page item from generated nav and renders NotificationsSidebarItem manually. |
| src/packages/app/package.json | Updates Backstage Community GitHub plugins and adds @backstage/plugin-app-module-user-settings. |
| src/packages/app/e2e-tests/app.test.ts | Makes sidebar assertion target the navigation landmark labeled “sidebar nav”. |
| src/backstage.json | Updates the Backstage release version reference to 1.53.2. |
| src/app-config.yaml | Renames client ID metadata documents config key but (currently) places it at root level. |
| src/.yarnrc.yml | Updates Backstage Yarn plugin checksum and release URL to 1.53.2. |
| src/.yarn/plugins/@yarnpkg/plugin-backstage.cjs | Updates the vendored Backstage Yarn plugin bundle. |
Review details
- Files reviewed: 9/10 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.