fix: удалить мёртвую регистрацию AddScoped<TableRenderCoordinator> (#108)#113
Merged
Conversation
) Координатор всегда создаётся через ActivatorUtilities от root-провайдера, scope в кодовой базе не создаётся ни разу — регистрация только вводила в заблуждение и противоречила architecture.md («do not register these types in the container»). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #108. Завершает остаток issue: п.1 (Dispose координатора в
DisposeRuntimeComponentsобоих контролов) был закрыт в #112, здесь — п.2.Что сделано
Удалена мёртвая регистрация
services.AddScoped<TableRenderCoordinator>()изDiContainer.cs.Обоснование безопасности удаления
TableRenderCoordinatorиз контейнера не существует — координатор создаётся только черезActivatorUtilities.CreateInstanceв обоих шеллах (TableControl.Lifecycle.cs:108,MbeTableEditorControl.Lifecycle.cs:107).CreateScope()в кодовой базе не вызывается ни разу — scoped-регистрация недостижима в принципе.architecture.md(«Control-side composition») прямо фиксирует правило «do not register these types in the container» — правка приводит код в соответствие с документацией.Поведение не меняется; рантайм-валидация в MasterSCADA не требуется. 290/290 тестов зелёные,
dotnet formatчистый.🤖 Generated with Claude Code