feat(codex): support provider-specific review models - #451
Open
neverdie0710 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex providers can now choose their own review model in the TUI. For example, switching from provider A to B projects A’s or B’s selection into the top-level
review_modelused by Codex, without requiring separateCODEX_HOMEdirectories.The optional selection is stored as
meta.codexReviewModeland takes precedence over common config. Leaving it empty preserves existing configuration behavior. Preview, normal switching, temporary launches and shared-session launches honor the override; live-config backfill preserves the underlying value so clearing an override restores the previous behavior, including clearing while a temporary launch is still running. Chat/Anthropic model routing also preserves an explicitly selected review model even when it is absent from the model catalog.Includes English/Chinese UI help and README documentation, plus regression coverage for persistence, common-config precedence, clearing after backfill, official providers without metadata, both launch paths, routing and narrow-terminal rendering.
Validation:
cargo fmt --checkprovider_serviceintegration tests and all ninestart_codex_sharedtests pass.8a5614db(codex_refresh_keeps_the_selected_message_when_prepend_moves_its_page: unable to open temporary SQLite index).cargo clippy --all-targets --lockedis blocked by the existingclippy::reversed_empty_rangeserror insrc/cli/tui/ui/home_chart.rs:806, also with the pinned Rust 1.91.1 toolchain. With only that lint allowed, the all-target Clippy check passes (existing warnings remain). No unrelated lint or transcript-index changes are included.