Skip to content

fix(proxy): ignore empty legacy function_call placeholders #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
u1544096979 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(proxy): ignore empty legacy function_call placeholders #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion src-tauri/src/proxy/providers/streaming.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,16 @@ pub fn create_anthropic_sse_stream(
legacy_function_name = Some(name.clone());
}

if function_call.name.is_some() || function_call.arguments.is_some() {
let has_legacy_function_payload = function_call
.name
.as_deref()
.is_some_and(|name| !name.is_empty())
|| function_call
.arguments
.as_deref()
.is_some_and(|arguments| !arguments.is_empty());

if has_legacy_function_payload {
if let Some(index) = current_non_tool_block_index.take() {
let event = json!({
"type": "content_block_stop",
Expand Down Expand Up @@ -1193,6 +1202,26 @@ mod tests {
);
}

#[tokio::test]
async fn empty_legacy_function_call_does_not_emit_tool_use() {
let input = concat!(
"data: {\"id\":\"chatcmpl_1\",\"model\":\"glm-5.3-flash\",\"choices\":[{\"delta\":{\"content\":\"ok\",\"function_call\":null}}]}\n\n",
"data: {\"id\":\"chatcmpl_1\",\"model\":\"glm-5.3-flash\",\"choices\":[{\"delta\":{\"function_call\":{\"name\":\"\",\"arguments\":\"\"}},\"finish_reason\":\"stop\"}],\"usage\":{\"prompt_tokens\":1,\"completion_tokens\":1}}\n\n",
"data: [DONE]\n\n"
);

let events = collect_events(input).await;
assert!(!events.iter().any(|event| {
event["type"] == "content_block_start"
&& event["content_block"]["type"] == "tool_use"
}));
assert!(events.iter().any(|event| {
event["type"] == "message_delta"
&& event["delta"]["stop_reason"] == "end_turn"
}));
assert!(events.iter().any(|event| event["type"] == "message_stop"));
}

#[tokio::test]
async fn legacy_function_call_stream_emits_tool_use_block_and_argument_delta() {
let input = concat!(
Expand Down
Loading