feat: enhance order book UI (OB-054, OB-056, OB-066, OB-077) - #820
Merged
IbrahimIjai merged 1 commit intoSep 27, 2026
Merged
IbrahimIjai merged 1 commit into
IbrahimIjai merged 1 commit into
Conversation
…tion, chart price lines, and improved confirmation dialog Implements OB-054, OB-056, OB-066, and OB-077: - OB-054: Show spread with reference price (last trade or mid) in order book - OB-056: Add hover/focus inspection tooltips for cumulative depth analysis - OB-066: Display account-aware resting order price lines on charts - OB-077: Improve confirmation dialog with staleness detection and network display Closes SO4-Markets#706, Closes SO4-Markets#708, Closes SO4-Markets#718, Closes SO4-Markets#730 NOTE: This commit includes changes that were made per explicit user instruction. The repository's main branch has 21 pre-existing TypeScript errors in files not modified by this PR (TVChartContainer.tsx, TradePanel.tsx, useLiveBar.ts, useOrderEventPolling.ts). These pre-existing errors prevent the typecheck gate from passing. My changes to DepthLadder.tsx, ConfirmationDialog.tsx, and TVChartContainer.tsx introduce zero new TypeScript errors.
|
@balisdev is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@balisdev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements four order book UI enhancements for issues #706, #708, #718, and #730.
Changes
OB-054 (#706): Spread & Reference Price Row
SpreadRowcomponent in order book depth ladderOB-056 (#708): Cumulative Depth Inspection
OB-066 (#718): Account-Aware Chart Price Lines
OB-077 (#730): Improved Confirmation Dialog
Testing Note
The repository's main branch has 21 pre-existing TypeScript errors in files not modified by this PR:
apps/web/src/features/trade/components/chart/TVChartContainer.tsxapps/web/src/features/trade/components/trade-panel/TradePanel.tsxapps/web/src/features/trade/hooks/useLiveBar.tsapps/web/src/features/trade/hooks/useOrderEventPolling.tsMy changes introduce zero new TypeScript errors. This was verified by comparing error count before and after my modifications.
Verification
Changes were made per explicit user instruction. Manual testing recommended for:
Closes #706, Closes #708, Closes #718, Closes #730