Move airport/runway fetch to background context in BasePerformanceViewModel#4
Merged
RISCfuture merged 2 commits intomainfrom Apr 12, 2026
Merged
Move airport/runway fetch to background context in BasePerformanceViewModel#4RISCfuture merged 2 commits intomainfrom
RISCfuture merged 2 commits intomainfrom
Conversation
…wModel Contributes to fixing SF50-TOLD-1X (DB on main thread). The airport and runway observation task in setupObservation() previously used container.mainContext for findAirportAndRunway fetches, causing SwiftData queries to run on the main thread. Replaces the stored context property with container. The observation task is now Task.detached, fetching on a fresh background ModelContext per iteration. Results are returned as PersistentIdentifier values that cross actor boundaries cleanly, then rehydrated on MainActor via mainContext.model(for:) for property assignment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Drops the nonisolated static fetchAirportAndRunwayIDs helper in favor of inlining the fetch and PersistentIdentifier extraction directly in the Task.detached closure. SwiftData @model types cannot be safely sent across isolation boundaries under strict concurrency, so PersistentIdentifier (a Sendable value type) is extracted on the background context and the model is rehydrated via mainContext.model(for:) on MainActor. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code