feat: add StreamTrait::now() and overhaul StreamInstant API#1139
Open
roderickvd wants to merge 17 commits intomasterfrom
Open
feat: add StreamTrait::now() and overhaul StreamInstant API#1139roderickvd wants to merge 17 commits intomasterfrom
roderickvd wants to merge 17 commits intomasterfrom
Conversation
- Adds now() to StreamTrait so callers can query the stream clock outside the audio callback on the same time base as callback/capture/playback timestamps. - StreamInstant is reworked to mirror std::time::Instant with u64 storage (all stream clocks are monotonic and non-negative) and similar functions parameters, and return types. Closes #472
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
StreamTrait::now()so callers can query the stream clock outside the audio callback on the same time base as callback/capture/playback timestamps.Refactored
StreamInstantto mirrorstd::time::Instantwithu64storage (all stream clocks are monotonic and non-negative) and similar functions parameters, and return types.Closes #472