fix: repair test_wally_harness deepseek test after the Rust port (CI red on main) - #145
sanchitmonga22 wants to merge 1 commit into
Conversation
tests/test_wally_harness.rs called harness::build_deep_seek_settings, which the Rust port (#133) never defined — the real function is build_deep_seek_llm_config, and its JSON has providers at the top level rather than nested under llm-pi-ai. The mismatch fails to compile wally_rust_tests on every CI platform (windows, windows-arm64, macos, linux), so main has been red since the port merged. Verified: cargo test (all 20 binaries, 559 tests passing) and cargo clippy --all-targets both pass clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe DeepSeek harness declaration test now builds its LLM config with ChangesDeepSeek harness test
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change updates a test to check the header shape emitted by the config builder; no user-facing behavior changes or actionable merge risk are identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
No issues found across 1 file
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
Re-trigger cubic
|
Closing in favour of #147, which carries this same test fix (the DeepSeek harness-header test retargeted at |
Summary
mainhas been red on every CI platform (windows, windows-arm64, macos, linux) since the Rust port (Rust port of the wally CLI (stacked on #127) #133) merged:tests/test_wally_harness.rscallsharness::build_deep_seek_settings, a function the port never defined.build_deep_seek_llm_config, whose JSON putsprovidersat the top level rather than nested underllm-pi-ai. Rename the call and fix the assertion to match.Test plan
cargo testlocally: all 20 test binaries, 559 tests passing, 0 failedcargo clippy --all-targets: clean, no warningsSummary by cubic
Fixes the deepseek settings test that has kept every CI platform red on
mainsince the Rust port. The test calledbuild_deep_seek_settings, which the port never defined; it now calls the realbuild_deep_seek_llm_configand asserts onprovidersat the top level instead of nested underllm-pi-ai. Test-only change, no production code affected.Written for commit f64a52b. Summary will update on new commits.
Summary by CodeRabbit