Skip to content

fix: repair test_wally_harness deepseek test after the Rust port (CI red on main) - #145

Closed
sanchitmonga22 wants to merge 1 commit into
mainfrom
fix/deepseek-harness-test-rename
Closed

sanchitmonga22 wants to merge 1 commit into
mainfrom
fix/deepseek-harness-test-rename

Conversation

@sanchitmonga22

@sanchitmonga22 sanchitmonga22 commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • main has been red on every CI platform (windows, windows-arm64, macos, linux) since the Rust port (Rust port of the wally CLI (stacked on #127) #133) merged: tests/test_wally_harness.rs calls harness::build_deep_seek_settings, a function the port never defined.
  • The real function is build_deep_seek_llm_config, whose JSON puts providers at the top level rather than nested under llm-pi-ai. Rename the call and fix the assertion to match.
  • No production code changes — test-only fix.

Test plan

  • cargo test locally: all 20 test binaries, 559 tests passing, 0 failed
  • cargo clippy --all-targets: clean, no warnings
  • CI green on this PR (windows, windows-arm64, macos, linux)

Summary by cubic

Fixes the deepseek settings test that has kept every CI platform red on main since the Rust port. The test called build_deep_seek_settings, which the port never defined; it now calls the real build_deep_seek_llm_config and asserts on providers at the top level instead of nested under llm-pi-ai. Test-only change, no production code affected.

Written for commit f64a52b. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Tests
    • Updated checks for DeepSeek provider configuration to verify that provider headers are read from the current configuration structure. This keeps validation aligned with how provider settings are organized.

tests/test_wally_harness.rs called harness::build_deep_seek_settings,
which the Rust port (#133) never defined — the real function is
build_deep_seek_llm_config, and its JSON has providers at the top
level rather than nested under llm-pi-ai. The mismatch fails to
compile wally_rust_tests on every CI platform (windows, windows-arm64,
macos, linux), so main has been red since the port merged.

Verified: cargo test (all 20 binaries, 559 tests passing) and
cargo clippy --all-targets both pass clean.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@sanchitmonga22
sanchitmonga22 requested a review from a team as a code owner September 28, 2026 05:38
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 40dafa4b-46c1-428f-ad53-8a757162db96

📥 Commits

Reviewing files that changed from the base of the PR and between 39e39c0 and f64a52b.

📒 Files selected for processing (1)
  • tests/test_wally_harness.rs

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The DeepSeek harness declaration test now builds its LLM config with build_deep_seek_llm_config and checks provider headers at providers.runanywhere.headers.

Changes

DeepSeek harness test

Layer / File(s) Summary
Update harness assertion
tests/test_wally_harness.rs
The test uses build_deep_seek_llm_config and checks providers.runanywhere.headers instead of the former nested path.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to f64a5

The change updates a test to check the header shape emitted by the config builder; no user-facing behavior changes or actionable merge risk are identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the test repair, names the affected test, and provides relevant context about the Rust port and CI failure.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.

Re-trigger cubic

@sanchitmonga22

Copy link
Copy Markdown
Collaborator Author

Closing in favour of #147, which carries this same test fix (the DeepSeek harness-header test retargeted at build_deep_seek_llm_config) together with the rest of the wrap-up. This PR was opened by an automated helper during that work.

@sanchitmonga22
sanchitmonga22 deleted the fix/deepseek-harness-test-rename branch September 28, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant