docs(llm): update generate_stream token_callback docstring for UTF-8 … - #928
Sarah-Mahmoud-29 wants to merge 1 commit into
Conversation
…runs Fixes RunanywhereAI#923. Updates rac_llm_component_generate_stream docstring to reflect UTF-8 text runs instead of per-token delivery.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe public documentation for ChangesLLM callback documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The callback documentation now matches the existing chunked UTF-8 delivery behavior, with no merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for this, @Sarah-Mahmoud-29! Correcting the streaming docstring to describe UTF-8-safe text runs instead of raw tokens is exactly the right fix -- it matches how the llama.cpp backend actually chunks output and the ABI v9 typedef's own note that a delta can coalesce multiple tokens. Before we merge, one thing to sort out:
Optional, not required: the callback typedef doc two lines above in this same file ( Not blocking this PR: I opened #929 for keeping the VLM/Swift-bindings sibling headers in sync with this same wording -- you're welcome to pick it up if you're interested. Once that's in we'll take another look. Thanks again! Reviewed with help from Claude Code and Codex. |
…runs
Fixes #923. Updates rac_llm_component_generate_stream docstring to reflect UTF-8 text runs instead of per-token delivery.
Description
Brief description of the changes made.
Type of Change
Testing
Platform-Specific Testing (check all that apply)
Swift SDK / iOS Sample:
Kotlin SDK / Android Sample:
Flutter SDK / Flutter Sample:
React Native SDK / React Native Sample:
Web SDK / Web Sample:
Labels
Please add the appropriate label(s):
SDKs:
Swift SDK- Changes to Swift SDK (bindings/swift)Kotlin SDK- Changes to Kotlin SDK (bindings/kotlin)Flutter SDK- Changes to Flutter SDK (bindings/flutter)React Native SDK- Changes to React Native SDK (bindings/react-native)Web SDK- Changes to Web SDK (bindings/web)Commons- Changes to shared native code (core)Sample Apps:
Flutter Sample- Changes to Flutter example app (bindings/flutter/example)React Native Sample- Changes to React Native example app (bindings/react-native/example)Minimal Examples- Changes to an in-repo SDK harness (bindings/{swift,kotlin,web}/example)The iOS, Android, Web, and Electron consumer apps live in their own
repositories (
RunanywhereAI/runanywhere-{ios,android,web,electron}) — openthose PRs there.
Checklist
Screenshots
Attach relevant UI screenshots for changes (if applicable):
Summary by CodeRabbit