chore: delete the three workflows under core/.github by ayaangazali · Pull Request #789 · RunanywhereAI/runanywhere-sdks

ayaangazali · 2026-08-25T16:59:38Z

Description

core/.github/workflows/ holds three workflow files. GitHub Actions only reads .github/workflows/ at the repository root, so nothing in that directory has ever run here.

core/.github/workflows/build-commons.yml   137 lines
core/.github/workflows/release.yml         292
core/.github/workflows/size-check.yml       86
                                           515 total

They are leftovers from when commons was its own repository, carried along by the 0.20.17 restructure (#665, the last commit to touch that path) rather than maintained. Three independent signs of that:

Stale action pin. They use actions/checkout@v4; every live workflow is on @v7.
Stale path filters. build-commons.yml and size-check.yml filter on include/**, src/**, cmake/**, CMakeLists.txt. paths: is evaluated from the repo root, and this repo has no top-level include/ or src/ — those describe the pre-restructure standalone layout, not core/include and core/src.
Superseded. The root release.yml publishes a superset: the dead copy names RACommons-android-* and RACommons-ios-*, the live one produces those plus RACommons-linux-* and the rest.

Nothing can reach them either. No file in the repo mentions core/.github (grepped *.yml, *.sh, *.md, *.py), none of the three declares workflow_call, so they are not reusable workflows another job could invoke, and core/ is not synced or mirrored to any other repository where they would execute.

Deleting rather than fixing: a workflow that cannot run is not worth repairing, and leaving it invites someone to edit it expecting an effect.

Type of Change

Bug fix
New feature
Documentation update
Refactoring

Testing

Lint passes locally — no lintable source changed; this is a pure deletion of three unreferenced YAML files
Added/updated tests for changes — not applicable to deleting dead CI config

Ran the full gate suite on the branch. Everything passes except two failures that are pre-existing on main and unrelated:

check_no_hardcoded_defaults.sh — mapfile: command not found, macOS bash 3.2, the subject of my open fix(gates): drop mapfile so the hardcoded-defaults gate runs on macOS #729
check_rn_cpp_headers_compile.sh — needs yarn install in bindings/react-native, environmental

Also confirmed .github/workflows/ at the root is untouched (still 11 files) and core/.github is now empty.

Platform-Specific Testing

Not applicable, no platform code changed.

Labels

Closest is core by path, though nothing in the built core library changes.

Checklist

Code follows project style guidelines
Self-review completed
Documentation updated (if needed) — no doc references these files

Screenshots

Not applicable.

Summary by CodeRabbit

Chores
- Removed automated build verification for macOS, iOS, Android, and C++.
- Removed automated packaging and publishing of iOS and Android library releases.
- Removed pull request size checks for the iOS framework, including generated size reports and size-limit validation.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

coderabbitai · 2026-08-25T17:00:56Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 3b1021b9-bdf2-47f0-a700-1ec01ec677b4

📥 Commits

Reviewing files that changed from the base of the PR and between 488cf27 and af5241f.

📒 Files selected for processing (3)

core/.github/workflows/build-commons.yml
core/.github/workflows/release.yml
core/.github/workflows/size-check.yml

💤 Files with no reviewable changes (3)

core/.github/workflows/build-commons.yml
core/.github/workflows/release.yml
core/.github/workflows/size-check.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Walkthrough

Three GitHub Actions workflows were deleted. They previously handled RACommons build validation, release publishing, and iOS framework size checks.

Changes

RACommons workflow removal

Layer / File(s)	Summary
Build validation workflow removal `core/.github/workflows/build-commons.yml`	Deletes macOS, iOS, Android, and C++ validation jobs and artifact uploads.
Release publishing workflow removal `core/.github/workflows/release.yml`	Deletes version preparation, iOS and Android builds, checksum generation, package publishing, tagging, and GitHub release creation.
Framework size-check workflow removal `core/.github/workflows/size-check.yml`	Deletes iOS XCFramework size analysis, limit enforcement, report generation, and artifact upload.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to af524

The change only removes inactive nested workflow files; no merge-blocking risk was identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the deletion of the three workflows under core/.github and accurately summarizes the main change.
Description check	✅ Passed	The description is complete and relevant. It explains the rationale, lists the deleted workflows, identifies the refactoring type, documents testing and unrelated failures, and addresses platform test…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

GitHub only reads .github/workflows at the repository root, so nothing under core/.github has ever run in this monorepo. The root already has the live equivalents, and its release.yml publishes a superset of the assets this copy described. They were carried along by the 0.20.17 restructure (RunanywhereAI#665) rather than maintained: they still pin actions/checkout@v4 where the live workflows are on v7, and their path filters are include/** and src/**, which describe the old standalone-commons layout rather than core/include and core/src.

ayaangazali · 2026-09-04T03:03:22Z

Still reproduces on 45e91276e (0.20.36). First ping on this one.

The three workflow files are still there:

$ ls core/.github/workflows/
build-commons.yml
release.yml
size-check.yml

GitHub only ever runs workflows from .github/workflows/ at the repository root, so a nested core/.github/workflows/ is inert: these three have never executed and cannot. The risk is not the wasted files, it is that they read as coverage. build-commons.yml in particular looks like the commons build gate while the real one lives in the root pr-build.yml.

Deleting them is the whole diff. Merges clean, no conflicts.

sanchitmonga22 · 2026-09-11T01:02:28Z

@coderabbitai full review

coderabbitai · 2026-09-11T01:02:34Z

✅ Action performed

Full review finished.

sanchitmonga22 · 2026-09-11T02:53:14Z

Thanks for this, @ayaangazali! The change looks good — the diff is exactly what it says, a clean deletion of the three inert workflow files under core/.github/workflows/.

One small, optional thing while it waits: core/AGENTS.md:290-293 still describes those workflows as live ("This directory carries its own .github/workflows/…", then build-commons.yml and size-check.yml). Dropping or rewording that section in this PR would keep the docs in step with the deletion.

Because it touches CI/automation files (build-commons.yml, release.yml, size-check.yml — files that would run with the repo's tokens if GitHub ever read them), a maintainer will give that part a final look before merging.

Reviewed with help from Claude Code and Codex.

sanchitmonga22 · 2026-09-11T02:53:16Z

Replying to this comment

That makes sense — thanks for explaining! We verified independently that these three files never ran: GitHub only reads workflows from the repository root, and none of this repo's registered workflows live under core/, so your reasoning holds. The one leftover is core/AGENTS.md:290-293, which still describes them (see the note above). Because the change touches CI/workflow files, a maintainer will still give it a final look before merging — thanks for your patience.

Reviewed with help from Claude Code and Codex.

Copilot AI lite review requested due to automatic review settings August 25, 2026 16:59

Copilot AI reviewed Aug 25, 2026

ayaangazali force-pushed the chore/remove-dead-nested-workflows branch from a230d0d to af5241f Compare September 2, 2026 19:17

Navigation Menu

chore: delete the three workflows under core/.github - #789

chore: delete the three workflows under core/.github#789
ayaangazali wants to merge 1 commit into
RunanywhereAI:mainfrom
ayaangazali:chore/remove-dead-nested-workflows

ayaangazali commented Aug 25, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai Bot commented Aug 25, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

ayaangazali commented Sep 4, 2026

Uh oh!

sanchitmonga22 commented Sep 11, 2026

Uh oh!

coderabbitai Bot commented Sep 11, 2026 •

edited

Loading

Uh oh!

sanchitmonga22 commented Sep 11, 2026

Uh oh!

sanchitmonga22 commented Sep 11, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ayaangazali commented Aug 25, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Testing

Platform-Specific Testing

Labels

Checklist

Screenshots

Summary by CodeRabbit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

ayaangazali commented Sep 4, 2026

Uh oh!

sanchitmonga22 commented Sep 11, 2026

Uh oh!

coderabbitai Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanchitmonga22 commented Sep 11, 2026

Uh oh!

sanchitmonga22 commented Sep 11, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ayaangazali commented Aug 25, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 25, 2026 •

edited

Loading

coderabbitai Bot commented Sep 11, 2026 •

edited

Loading