[Feat] Configure Statuspage incident feed by URL - #1194
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
R_STATUSPAGE_INCIDENTS_URLsetting.Why
The incident feed location is deployment configuration, not an application constant. Leaving the variable unset now cleanly disables incident banners and Slack warnings.
Impact
Managed deployments must set
R_STATUSPAGE_INCIDENTS_URLto retain the feature. The retired marker no longer enables it.Companion managed-fleet propagation: https://github.com/RooCodeInc/Roomote-Cloud/pull/183
Validation
mise exec -- pnpm lintmise exec -- pnpm check-typesmise exec -- pnpm --filter @roomote/docs checkmise exec -- pnpm --filter @roomote/env test -- --run src/__tests__/index.test.tsmise exec -- pnpm --filter @roomote/slack test -- --run src/__tests__/statuspage-incidents.test.ts