[Fix] Ordinary tasks can access environment management tools - #1109
Draft
roomote-community[bot] wants to merge 3 commits into
Draft
[Fix] Ordinary tasks can access environment management tools#1109roomote-community[bot] wants to merge 3 commits into
roomote-community[bot] wants to merge 3 commits into
Conversation
Contributor
Author
|
No new code issues found. See task
Reviewed e45f569 |
Contributor
Author
|
Fixed the enqueue trust boundary in e45f569: user-authenticated launches now reject explicit environment-management markers, verification markers, and forged setup-workflow classification before queueing. Focused SDK tests, SDK typechecking, formatting, and the repository pre-push checks pass. See task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
manage_environmentsfrom ordinary tasks and restrict setup tasks to only their required create, update, or verification actions.Why this change was made
Environment management was registered for every task even though only environment setup and verification flows need it. The admin authorization added in #1102 remains the identity boundary; this change adds least-privilege task-purpose scoping around that boundary.
Impact
Ordinary coding tasks no longer discover or invoke environment management and cannot self-grant it through
taskRuns.enqueue. Creation setup can create, revise, and verify its environment; existing-environment setup can update and verify; verification retries can only record verification.The focused worker, API, web, SDK, and shared-type checks pass, along with the repository pre-push suite. The full preview-status test file still times out in its pre-existing first database-backed test in this sandbox; the changed preview repair test passes when run directly.
Related PRs