Fix: avoid crashes on zip IO errors#32
Open
official-markus-maurer wants to merge 1 commit intoRomVault:masterfrom
Open
Fix: avoid crashes on zip IO errors#32official-markus-maurer wants to merge 1 commit intoRomVault:masterfrom
official-markus-maurer wants to merge 1 commit intoRomVault:masterfrom
Conversation
- Treat IOException during FixAZip as FileSystemError so fix passes report and continue - Harden Zip finalizer/failed-close paths to never throw during GC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should prevent the hardcrash Braintrash reported on Discord.
Treat IOException during FixAZip as FileSystemError so fix passes report and continue
Harden Zip finalizer/failed-close paths to never throw during GC