Perf/simd byte equality#25
Open
official-markus-maurer wants to merge 5 commits intoRomVault:masterfrom
Open
Conversation
- Optimize buffer copying using Buffer.BlockCopy instead of manual loop - Add reference equality check in ByteArrCompare for performance - Initialize altsha256 thread when scanSHA256 is true - Fix incorrect buffer size passed to tsha256.Trigger calls
- Replace manual string comparison with String.Equals in CompareString - Simplify CompareStringSlash logic and add case-insensitive comparison - Replace BlockingCollection with ArrayPool for buffer management - Move empty hash constants to static readonly fields
Add reference equality check at the start of byte array comparison methods to avoid unnecessary element-by-element comparison when arrays are the same instance. This improves performance for cases where identical array references are compared.
Add MethodImplOptions.AggressiveInlining to byte array comparison methods across multiple files to improve performance. Also optimize progress reporting in FileScan by using string.Concat and adjusting reporting frequency.
Add System.Memory package to multiple projects to enable Span<T> usage Replace manual byte array equality checks with more efficient Span.SequenceEqual
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key Changes
Byte array equality (SIMD path):
Imports for MemoryExtensions :
Package support for netstandard2.0 :
Misc micro-optimizations (earlier commits visible in history):
Performance Impact