feat: enforce vesting cliff_secs gate before pro-rata accrual - #865
Merged
thlpkee20-wq merged 1 commit intoAug 31, 2026
Merged
Conversation
|
@ugoocreates-pixel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #853
Implements vesting cliff support with a discrete
cliff_secsgate before any pro-rata accrual begins, enforcing a hard zero claim before the cliff while preserving schedule arithmetic afterward.Changes:
cliff_secs: u64parameter to theVestingSchedulestruct and thevesting_registerregistration function.VestingCliffNotReached(109) error to theVestingErrorenum to avoid silently returning zero when attempting to claim before the cliff.compute_vestedto strictly return 0 if the current timestamp is less thanstart_ts.saturating_add(cliff_secs).VestingCliffNotReachedcheck investing_claimprior to computing claimable tokens.vesting_test.rscovering happy paths, pre-cliff error emissions, and boundary conditions (exactly atstart_ts + cliff_secs). Existing deployment API compatibility rules are maintained.