Add taxation-bucket tagging on report_revenue (ordinary, capital, return-of-capital)

[Jagadeeshftw]

Summary

Add taxation-bucket tagging on report_revenue (ordinary, capital, return-of-capital)

Why this matters

Revenue-share distributions have different tax treatments (ordinary income, capital gains, return of capital). Add a TaxBucket field on report_revenue so downstream indexers and tax engines can categorize each disbursement without out-of-band annotation.

Scope

Implement the requested behavior across Revora-Contracts/src/lib.rs. The solution must preserve existing compatibility, authorization, and production safeguards.

Priority

High

Acceptance criteria

• The requested behavior is implemented across Revora-Contracts/src/lib.rs with a clear, reviewable contract.
• Security, authorization, validation, and data-integrity requirements in the repository context are enforced and covered by tests.
• Failure, retry, timeout, concurrency, and boundary behavior is explicit and produces safe, diagnosable outcomes where applicable.
• Regression coverage includes empty, invalid, duplicate, and boundary inputs relevant to this flow.
• Existing API, storage, and deployment compatibility is preserved unless a migration is explicitly documented.

Validation

Include focused tests for:

• happy paths;
• invalid input and authorization boundaries;
• concurrency, retries, or failure recovery;
• backward compatibility;
• relevant integration or contract behavior.

The implementation must pass the repository’s existing build, lint, test, and formatting checks (use cargo test --all where applicable).

Non-goals

• Typo-only, formatting-only, or documentation-only changes.
• Unrelated refactors or dependency upgrades.
• Weakening security, authorization, CI, or production safeguards.
• Changing public behavior outside this issue’s scope.

Contributor application

Before implementation, comment with:

1. relevant experience;
2. a concise implementation approach;
3. expected files or modules affected;
4. an estimate for opening the first PR.

Wait for maintainer assignment before coding.

PR requirements

Use a feature branch and include Closes #.

The PR must:

• address every acceptance criterion;
• link each criterion to code and tests;
• explain security and failure-mode handling;
• include meaningful regression coverage;
• document compatibility or migration considerations;
• pass the repository checks.

Reward-readiness

This is a substantive quality issue. Merge status does not guarantee reward eligibility; final evaluation is determined separately.

Implementation context

Description

Revenue-share distributions have different tax treatments (ordinary income, capital gains, return of capital). Add a TaxBucket field on report_revenue so downstream indexers and tax engines can categorize each disbursement without out-of-band annotation.

Requirements and context

• Must be secure, tested, and documented
• Should be efficient and easy to review
• Relevant code: Revora-Contracts/src/lib.rs
• Bucket must be encoded into the indexed event topic for filterable subscription

Suggested execution

• Fork the repo and create a branch
• git checkout -b feat/tax-bucket-tagging
• Implement changes
  • Add enum TaxBucket { Ordinary, Capital, ReturnOfCapital, Custom(Symbol) }
  • Persist bucket in PeriodRevenue and surface it on claim events
  • Document mapping to common jurisdictions in README
• Validate security and correctness assumptions

Test and commit

• Run tests
  • cargo test --all
• Cover edge cases
  • Override revenue must preserve original bucket unless explicitly overridden
• Include test output and security notes

Example commit message

feat: tag report_revenue with TaxBucket for downstream tax engines

Guidelines

• Minimum 95 percent test coverage
• Clear documentation
• Timeframe: 96 hours

[drips-wave]

⚠️ @thlpkee20-wq: @Jagadeeshftw has been assigned to this issue but hasn't applied to it via Drips Wave.

This issue is still part of the Stellar Wave Program, so Wave contributors can still apply and be assigned. If you'd rather hand it off outside of Wave, remove the Stellar Wave label to take this issue out of the Wave Program.

[Muyideen-js]

@Muyideen-js has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi, I can fix this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Muyideen-js to this issue.

[dollfins]

@dollfins has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

hello maintainer, can i work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @dollfins to this issue.

[drips-wave]

Congratulations, @Muyideen-js! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @Muyideen-js: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox!

@Muyideen-js's PR #858 was approved and merged by @thlpkee20-wq.

🏆 @Muyideen-js: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,345 total points). Track your full progress on GrantFox.

👏 Great work, @Muyideen-js! Keep contributing to RevoraOrg.