Add subtitles, playlist booklets, and safer production installs - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Bird Player is being used as a daily player, so subtitles and playlist context need to travel with the media while development and upgrades must not risk the production library database.
User impact
Users can download and view timed subtitles, maintain portable playlist booklets, and upgrade the installed application with database backup and rollback protection. Existing databases are migrated rather than rebuilt, and unknown/newer schemas are refused safely.
Validation
cargo fmt --all -- --checkcargo test --all-targets— 42 passedcargo bundle --release --features production-datagit diff --check