Skip to content

[Quality][Medium] Add accessible focus and announcement behavior to critical dialogs #1637

Description

@Baskarayelu

Objective

Implement reusable focus, labeling, escape, and live-region behavior for critical modal flows.

Why this matters

Wallet, payment, error, and confirmation dialogs are critical interaction boundaries; broken focus or missing announcements can prevent completion or cause accidental actions.

This is a substantive production-quality improvement. It must change runtime behavior, security guarantees, correctness, reliability, or meaningful user functionality. It is not a documentation-only, formatting-only, or trivial dependency task.

Scope

Area: accessibility and interaction

Starting points: components, components/AsyncSubmissionStatus.tsx, components/SessionExpiryNotification.tsx, lib/a11y

The contributor should verify the current implementation before changing it and keep the PR limited to this issue. Do not introduce unrelated refactors or weaken existing CI/security gates.

Acceptance criteria

  • Focus enters and returns correctly for every critical dialog.
  • Loading, success, failure, and destructive warnings are announced accessibly.
  • Keyboard users cannot activate a background action while a modal is open.
  • The default focus never triggers a destructive/signing action accidentally.

Required validation

  • Add keyboard and accessibility tests for payment, auth, error, and emergency dialogs.

  • Test modal replacement during async state transitions.

  • Run automated WCAG/axe checks in CI.

  • The PR explains the failure mode, the chosen design, backward-compatibility impact, and rollback or migration considerations.

  • The PR includes CI evidence and does not contain secrets, generated noise, unrelated cleanup, or disabled checks.

Contributor deliverables

  • Open a focused feature branch and do not begin implementation until assigned.
  • Reference this issue with Closes #<issue-number> or Fixes #<issue-number>.
  • Check off every acceptance criterion in the PR with links to the relevant code and tests.
  • Include a security/correctness note explaining why adversarial inputs cannot bypass the new guarantee.

Maintainer quality bar

The PR must be independently reviewable, preserve existing behavior outside this scope, exercise failure paths, and pass the repository's complete required CI/CD checks. Reward eligibility is not guaranteed by this issue or by merging.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions