Skip to content

fix(git-service): grab the Clowder private port instead of hardcoded port - #483

Merged
justinorringer merged 1 commit into
RedHatInsights:mainfrom
hossam-farid:update-clowder-port
Aug 12, 2026
Merged

fix(git-service): grab the Clowder private port instead of hardcoded port#483
justinorringer merged 1 commit into
RedHatInsights:mainfrom
hossam-farid:update-clowder-port

Conversation

@hossam-farid

@hossam-farid hossam-farid commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

RHCLOUD-49988

On Init grab the Clowder Private port instead of the hardcoded port


How to test locally


Anything reviewers should know?


Checklist

  • Tests: new/updated tests cover the change
  • API: spec updated if endpoints changed (or N/A)
  • Migrations: backwards compatible if schema changed (or N/A)
  • Dependencies: no known impact to dependent services
  • Security: reviewed against secure coding checklist (or N/A)

AI disclosure

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@hossam-farid, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0e5ecec7-e2f5-47ea-a007-8b374fac705a

📥 Commits

Reviewing files that changed from the base of the PR and between b9f1eda and 7375ab1.

📒 Files selected for processing (1)
  • deploy/git-service-clowdapp.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 04d11794-3fe5-4f75-a72d-8bfdb814bb19

📥 Commits

Reviewing files that changed from the base of the PR and between 670c688 and b9f1eda.

📒 Files selected for processing (1)
  • pkg/git-service/config/config.go

Summary by CodeRabbit

  • Bug Fixes
    • Corrected private port handling when Clowder integration is enabled, ensuring the configured port is applied correctly.

Walkthrough

The git service configuration now uses the configured Clowder private port when Clowder is enabled. The port is formatted as a decimal string before assignment.

Changes

Clowder port configuration

Layer / File(s) Summary
Apply the Clowder private port
pkg/git-service/config/config.go
The configuration formats lcfg.PrivatePort as a decimal string and assigns it to cfg.Port when Clowder is enabled and the private port is configured.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes the issue and change summary, but testing steps, reviewer notes, checklist responses, and AI disclosure are incomplete. Add local testing instructions, complete the reviewer notes and checklist, and state whether AI tools contributed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: using Clowder's private port instead of a hardcoded port.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hossam-farid

Copy link
Copy Markdown
Contributor Author

/retest

@hossam-farid
hossam-farid force-pushed the update-clowder-port branch 2 times, most recently from b9f1eda to fe7532a Compare August 11, 2026 23:51
@justinorringer
justinorringer merged commit a45165b into RedHatInsights:main Aug 12, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants