Skip to content

Change tab section divider to transparent - #371

Merged
apinkert merged 1 commit into
RedHatInsights:masterfrom
apinkert:fix-divider
Oct 1, 2026
Merged

apinkert merged 1 commit into
RedHatInsights:masterfrom
apinkert:fix-divider

Conversation

@apinkert

Copy link
Copy Markdown
Collaborator

For https://redhat.atlassian.net/browse/RHCLOUD-51760. Verified in dark mode as well.

Before:
image

After:
image

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: a2a38982-e088-4a02-99bb-c085d3979c6f

📥 Commits

Reviewing files that changed from the base of the PR and between 3217f83 and 2af18c7.

📒 Files selected for processing (1)
  • src/components/HelpPanel/HelpPanelCustomTabs.scss

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Summary by CodeRabbit

  • Style
    • Custom tab lists, items, and links now have transparent backgrounds, allowing the parent container’s white background to show through.

Walkthrough

The custom tabs now use transparent backgrounds for the tab list, items, and links. The updated comments describe the parent’s white background and the PatternFly bottom-border line.

Changes

Help panel tab backgrounds

Layer / File(s) Summary
Transparent tab backgrounds
src/components/HelpPanel/HelpPanelCustomTabs.scss
The tab list, items, and links now use transparent backgrounds instead of the primary background color. Comments describe the parent’s white background and the PatternFly bottom-border line.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 2af18

The parent surface remains themed while the divider shows through the tabs. No user-facing regression is evident, so the change appears ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: making the tab section divider transparent.
Description check ✅ Passed The description includes the issue reference, before-and-after screenshots, and dark mode verification. It does not follow the full template structure or include a detailed two-to-three-sentence summa…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@jjaquish jjaquish left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apinkert
apinkert merged commit 943874e into RedHatInsights:master Oct 1, 2026
9 checks passed
@apinkert
apinkert deleted the fix-divider branch October 1, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants