Repository navigation
Release polish for 1.0.0: lags in the config, steps as floats, atomic Run.save, release date check - #92
Merged
Conversation
…ps, atomic Run.save, release date check - Lags of inputs taken from the model (inputs=None) are kept in the preprocessing config until the inputs are resolved, so from_config (repeat_training) trains with the same inputs. - Numbers of steps given as whole floats (96.0) are steps instead of nanoseconds; other floats raise. - Run.save checks all target files before writing, a run without overwrite is not left half written. - Version Check requires a release date in the CHANGELOG entry of the tagged version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes from the final release review of 1.0.0.
inputs=None),lags={'T': 2}was not part ofget_config().PreprocessingData.from_config, and with itrepeat_training, then trained without the lagged inputs. The lags now stay in the config (lags) until the inputs are resolved, after that they are part ofinputs(lags: null). The key is additive, AgentLib-MPC only readstest_size,val_size,random_stateand the inputs/outputs._resolve_steps(96.0)gave 0, because pandas reads a number as nanoseconds.eval_horizon=96.0was therefore silently dropped. Whole floats are now steps, other floats raise aValueError.Run.savechecks before it writes: withoverwrite=False, the JSON configs used to be written before the check on the existing model file, so new configs ended up next to an old model. All target files are now checked first.YYYY-MM-DD), so a tag with## [1.0.0] – unreleasedfails.docs/release_1.0.0.mdis updated accordingly.Tests:
tests/test_preprocessing(lags round trip, steps as numbers) andtests/test_io/test_run.py(save stops before any file is written). Full suite locally: 274 passed, 1 skipped (RNN contract test, AgentLib-MPCmaininstalled).🤖 Generated with Claude Code