build: add missing includes for GCC 16 compatibility#117
Open
mrgswift wants to merge 1 commit into
Open
Conversation
Newer libstdc++ no longer transitively includes these headers, causing build failures on GCC 16. Add explicit includes where the symbols are used: - <unistd.h> for ::dup2/::close in spv-gen.cpp, Device.cpp, AudioOut.cpp - <climits> for INT_MAX in SharedCV.hpp - <mutex> for std::lock_guard in vfs.cpp
Contributor
|
Was this tested on both master and dev branches? Just checking I won't be able to look at this info for the next 15 hours. |
Author
|
@Darkhost1999 I only tested this on master. These are basically my hotfix changes to get this to build and compile with GCC 16. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Newer libstdc++ (as shipped with GCC 16) no longer transitively includes several headers that the codebase relies on, causing build failures. This adds explicit includes where the symbols are actually used:
<unistd.h>for::dup2/::closeinspv-gen.cpp,Device.cpp,AudioOut.cpp<climits>forINT_MAXinSharedCV.hpp<mutex>forstd::lock_guardinvfs.cppNotes
These are purely additive include fixes — no behavioral changes. This fixes compile errors in newer libstdc++ versions that have tightened their transitive include graph.