fix(router): don't resolve route loader to undefined on first SPA nav#8770
Open
briancarbone wants to merge 1 commit into
Open
fix(router): don't resolve route loader to undefined on first SPA nav#8770briancarbone wants to merge 1 commit into
briancarbone wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 03178b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
briancarbone
force-pushed
the
fix/loader-undefined-first-spa-nav
branch
from
c681c0c to
b80c3c5
Compare
briancarbone
force-pushed
the
fix/loader-undefined-first-spa-nav
branch
from
b80c3c5 to
3559b79
Compare
The loader's loaderPaths entry isn't seeded on the first client navigation to a route, so the signal computed to undefined instead of fetching, crashing components that read .value. Fall back to the current page path on the first read when no route path is available.
briancarbone
force-pushed
the
fix/loader-undefined-first-spa-nav
branch
from
3559b79 to
03178b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.