fix(qwik-router): rewrite() accepts same-origin absolute URLs and handles query strings#8718
Draft
maiieul wants to merge 2 commits into
Draft
fix(qwik-router): rewrite() accepts same-origin absolute URLs and handles query strings#8718maiieul wants to merge 2 commits into
maiieul wants to merge 2 commits into
Conversation
…dles query strings
Same-origin absolute URLs are normalized to a path and behave like a
relative rewrite (cross-origin and invalid URLs still 400). The rewrite
target's query is carried separately on RewriteMessage so it can't be
percent-encoded into the pathname: an explicit query replaces the
request's query, otherwise the original is kept; fragments are dropped.
Absolute-URL detection requires a protocol instead of startsWith('http').
🦋 Changeset detectedLatest commit: d499079 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
rewrite()now accepts same-origin absolute URLs by normalizing them to a path (cross-origin and invalid URLs still 400), and carries the target's query separately so it can't be percent-encoded into the pathname — an explicit query replaces the request's query, otherwise the original is kept; fragments are dropped. Split out of #8717.