Skip to content

Strip metadata from images/icons/emojis uploaded#3

Draft
winged-pegasus wants to merge 1 commit into
masterfrom
feat/strip-image-metadata
Draft

Strip metadata from images/icons/emojis uploaded#3
winged-pegasus wants to merge 1 commit into
masterfrom
feat/strip-image-metadata

Conversation

@winged-pegasus

@winged-pegasus winged-pegasus commented Jan 1, 2026

Copy link
Copy Markdown
Contributor

For privacy reasons, any images, emojis, or icons uploaded should be stripped of their metadata.

@winged-pegasus winged-pegasus changed the title strip metadata from images/icons/emojis uploaded Strip metadata from images/icons/emojis uploaded Jan 1, 2026
@lamat1111

Copy link
Copy Markdown
Contributor

Heads-up on where this stands after ~4 months of master moving:

Most of the surfaces this targets now strip metadata on master already, as a side effect of the compress/re-encode pipeline that was added since:

  • Message image attachments — re-encoded via ImageManipulator (JPEG) when over the size threshold; pickers also pass exif: false.
  • Profile avatars — compressAvatarImage re-encodes to JPEG.
  • Space icons (SpaceSettingsModal) and skins (SkinEditor) — same re-encode.

The one real remaining gap was the Farcaster Cloudflare upload (uploadImageToCloudflare / uploadImageForCast), which posted the raw URI un-stripped. I've picked that up in #129 (small targeted fix + exif: false on the onboarding picker, no new deps).

Two notes for if you revisit this branch: it forces SaveFormat.JPEG on emojis/stickers, which would flatten PNG transparency — emoji/sticker re-encodes should stay PNG. And it has committed modules/quorum-crypto/android/build/** and .idea/** artifacts that inflate the diff. Given master has diverged on imageAttachment.ts and ProfileModal.tsx, this likely won't rebase cleanly. Probably cleanest to close this in favour of #129 plus any small follow-up, but leaving it to you since it's your draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants