Skip to content

reapply docker build optimizations to Dockerfile.source #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CassOnMars merged 1 commit into from
Jun 18, 2026
Merged

reapply docker build optimizations to Dockerfile.source #568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 79 additions & 64 deletions docker/Dockerfile.source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,12 @@ WORKDIR /opt/ceremonyclient
# Rust workspace files (rarely change)
COPY Cargo.toml Cargo.lock ./

# Rust crate sources (needed by cargo build in generate.sh)
# Rust crate sources (needed by cargo build in gen-rust below).
# BuildKit normalizes mtimes on COPY, so cargo's mtime-based fingerprint
# check inside the target/ cache mount may over-rebuild. The cache mount
# still provides value for the registry/git caches and for cargo's
# content-derived intermediate artifacts; full mtime-based incrementality
# would require a host-side mtime normalization step (e.g. git restore-mtime).
COPY crates crates

# Gen-* module directories (Go wrappers + generate.sh scripts)
Expand Down Expand Up @@ -215,43 +220,43 @@ COPY go-libp2p-kad-dht/go.mod go-libp2p-kad-dht/go.sum go-libp2p-kad-dht/
COPY go-libp2p-blossomsub/go.mod go-libp2p-blossomsub/go.sum go-libp2p-blossomsub/

# -----------------------------------------------------------------------------
# Parallel Generation Stages
# Stage: gen-rust
# Purpose: Single cargo invocation that builds all seven leaf crates plus
# their uniffi-generated Go bindings. Shared workspace dependencies (quil-types,
# ed448-rust, classgroup, etc.) compile exactly once instead of seven times
# across parallel stages.
#
# Three cache mounts:
# - cargo-registry / cargo-git: shared across all stages and across the
# non-avx512 + avx512 Dockerfiles (pure function of Cargo.lock, identical
# downloaded source for both).
# - cargo-target-rust: per-stage; sharing the target dir with stages that
# have a different -p set would cause cargo fingerprint thrash.
#
# The cache-mounted /opt/ceremonyclient/target is NOT part of this stage's
# filesystem, so the .a artifacts are copied to /out/ before the mount
# unmounts. Downstream stages COPY --from=gen-rust /out/*.a instead.
# -----------------------------------------------------------------------------

FROM common-context AS gen-channel
WORKDIR /opt/ceremonyclient/channel
RUN go mod download
RUN ./generate.sh

FROM common-context AS gen-vdf
WORKDIR /opt/ceremonyclient/vdf
RUN go mod download
RUN ./generate.sh

FROM common-context AS gen-ferret
WORKDIR /opt/ceremonyclient/ferret
RUN go mod download
RUN ./generate.sh

FROM common-context AS gen-bls48581
WORKDIR /opt/ceremonyclient/bls48581
RUN go mod download
RUN ./generate.sh

FROM common-context AS gen-rpm
WORKDIR /opt/ceremonyclient/rpm
RUN go mod download
RUN ./generate.sh

FROM common-context AS gen-verenc
WORKDIR /opt/ceremonyclient/verenc
RUN go mod download
RUN ./generate.sh

FROM common-context AS gen-bulletproofs
WORKDIR /opt/ceremonyclient/bulletproofs
RUN go mod download
RUN ./generate.sh
FROM common-context AS gen-rust
WORKDIR /opt/ceremonyclient
RUN --mount=type=cache,id=cargo-registry,target=/root/.cargo/registry,sharing=locked \
--mount=type=cache,id=cargo-git,target=/root/.cargo/git,sharing=locked \
--mount=type=cache,id=cargo-target-rust,target=/opt/ceremonyclient/target \
cargo build --release \
-p channel -p vdf -p ferret -p bls48581 \
-p rpm -p verenc -p ed448-bulletproofs && \
mkdir -p /out && \
cp target/release/libchannel.a \
target/release/libvdf.a \
target/release/libferret.a \
target/release/libbls48581.a \
target/release/librpm.a \
target/release/libverenc.a \
target/release/libbulletproofs.a \
/out/ && \
for d in channel vdf ferret bls48581 rpm verenc bulletproofs; do \
uniffi-bindgen-go "crates/$d/src/lib.udl" -o "/opt/ceremonyclient/$d/generated"; \
done

# -----------------------------------------------------------------------------
# Stage: build-context
Expand All @@ -265,27 +270,17 @@ COPY --exclude=node \
--exclude=client \
--exclude=sidecar . .

# Copy generated artifacts back (overwrites source dirs with generated versions)
COPY --from=gen-channel /opt/ceremonyclient/channel /opt/ceremonyclient/channel
COPY --from=gen-channel /opt/ceremonyclient/target/release/libchannel.a /opt/ceremonyclient/target/release/libchannel.a

COPY --from=gen-vdf /opt/ceremonyclient/vdf /opt/ceremonyclient/vdf
COPY --from=gen-vdf /opt/ceremonyclient/target/release/libvdf.a /opt/ceremonyclient/target/release/libvdf.a

COPY --from=gen-ferret /opt/ceremonyclient/ferret /opt/ceremonyclient/ferret
COPY --from=gen-ferret /opt/ceremonyclient/target/release/libferret.a /opt/ceremonyclient/target/release/libferret.a

COPY --from=gen-bls48581 /opt/ceremonyclient/bls48581 /opt/ceremonyclient/bls48581
COPY --from=gen-bls48581 /opt/ceremonyclient/target/release/libbls48581.a /opt/ceremonyclient/target/release/libbls48581.a

COPY --from=gen-rpm /opt/ceremonyclient/rpm /opt/ceremonyclient/rpm
COPY --from=gen-rpm /opt/ceremonyclient/target/release/librpm.a /opt/ceremonyclient/target/release/librpm.a

COPY --from=gen-verenc /opt/ceremonyclient/verenc /opt/ceremonyclient/verenc
COPY --from=gen-verenc /opt/ceremonyclient/target/release/libverenc.a /opt/ceremonyclient/target/release/libverenc.a

COPY --from=gen-bulletproofs /opt/ceremonyclient/bulletproofs /opt/ceremonyclient/bulletproofs
COPY --from=gen-bulletproofs /opt/ceremonyclient/target/release/libbulletproofs.a /opt/ceremonyclient/target/release/libbulletproofs.a
# Copy generated artifacts back (overwrites source dirs with generated bindings).
# The .a files come from /out/ because gen-rust's target/ is a cache mount,
# not part of its filesystem.
COPY --from=gen-rust /opt/ceremonyclient/channel /opt/ceremonyclient/channel
COPY --from=gen-rust /opt/ceremonyclient/vdf /opt/ceremonyclient/vdf
COPY --from=gen-rust /opt/ceremonyclient/ferret /opt/ceremonyclient/ferret
COPY --from=gen-rust /opt/ceremonyclient/bls48581 /opt/ceremonyclient/bls48581
COPY --from=gen-rust /opt/ceremonyclient/rpm /opt/ceremonyclient/rpm
COPY --from=gen-rust /opt/ceremonyclient/verenc /opt/ceremonyclient/verenc
COPY --from=gen-rust /opt/ceremonyclient/bulletproofs /opt/ceremonyclient/bulletproofs
COPY --from=gen-rust /out/ /opt/ceremonyclient/target/release/

# -----------------------------------------------------------------------------
# Stage: build-node
Expand All @@ -297,7 +292,13 @@ WORKDIR /opt/ceremonyclient/node
# installs the binary at node/build/<platform>/node. The wildcard
# copy lets this same Dockerfile serve amd64/arm64 Linux builds
# without a platform switch.
RUN ./build.sh && cp build/*/node /usr/bin/node
# build.sh writes the final binary to node/build/<platform>/, outside
# the cache-mounted target/, so the cp after the && finds it on the
# real filesystem.
RUN --mount=type=cache,id=cargo-registry,target=/root/.cargo/registry,sharing=locked \
--mount=type=cache,id=cargo-git,target=/root/.cargo/git,sharing=locked \
--mount=type=cache,id=cargo-target-node,target=/opt/ceremonyclient/target \
./build.sh && cp build/*/node /usr/bin/node

# -----------------------------------------------------------------------------
# Stage: build-migrate-tool
Expand Down Expand Up @@ -329,32 +330,46 @@ RUN git clone --depth 1 --branch v${ROCKSDB_VERSION} https://github.com/facebook
cd .. && rm -rf rocksdb
COPY ./node /opt/ceremonyclient/node
WORKDIR /opt/ceremonyclient/node
RUN go mod download
RUN --mount=type=cache,id=go-build,target=/root/.cache/go-build,sharing=locked \
--mount=type=cache,id=go-mod,target=/root/go/pkg/mod,sharing=locked \
go mod download
ARG BINARIES_DIR=/opt/ceremonyclient/target/release
ENV ROOT_DIR=/opt/ceremonyclient
ENV CGO_ENABLED=1
ENV CGO_LDFLAGS="-L/usr/local/lib -lflint -lgmp -lmpfr -ldl -lm -L${BINARIES_DIR} -lstdc++ -lvdf -lchannel -lferret -lverenc -lbulletproofs -lbls48581 -lrpm -lcrypto -lssl -lrocksdb -lzstd -lsnappy -llz4 -lz -lbz2 -lpthread"
RUN GOOS=${TARGETOS} GOARCH=${TARGETARCH} \
RUN --mount=type=cache,id=go-build,target=/root/.cache/go-build,sharing=locked \
--mount=type=cache,id=go-mod,target=/root/go/pkg/mod,sharing=locked \
GOOS=${TARGETOS} GOARCH=${TARGETARCH} \
go build -tags rocksdb -ldflags "-linkmode 'external'" -o migrate-tool && \
cp migrate-tool /usr/bin/migrate-tool

# -----------------------------------------------------------------------------
# Stage: build-qclient
# Go cache mounts persist /root/.cache/go-build (compiled object cache) and
# /root/go/pkg/mod (module download cache) across docker builds. Without
# them, any invalidation of build-context (e.g., a file added to crates/)
# triggers a full from-scratch Go rebuild here.
# -----------------------------------------------------------------------------
FROM build-context AS build-qclient
ARG TARGETOS
ARG TARGETARCH

COPY ./node /opt/ceremonyclient/node
WORKDIR /opt/ceremonyclient/node
RUN go mod download
RUN --mount=type=cache,id=go-build,target=/root/.cache/go-build,sharing=locked \
--mount=type=cache,id=go-mod,target=/root/go/pkg/mod,sharing=locked \
go mod download

COPY ./client /opt/ceremonyclient/client
WORKDIR /opt/ceremonyclient/client
RUN go mod download
RUN --mount=type=cache,id=go-build,target=/root/.cache/go-build,sharing=locked \
--mount=type=cache,id=go-mod,target=/root/go/pkg/mod,sharing=locked \
go mod download

ARG BINARIES_DIR=/opt/ceremonyclient/target/release
RUN GOOS=${TARGETOS} GOARCH=${TARGETARCH} ./build.sh -o qclient
RUN --mount=type=cache,id=go-build,target=/root/.cache/go-build,sharing=locked \
--mount=type=cache,id=go-mod,target=/root/go/pkg/mod,sharing=locked \
GOOS=${TARGETOS} GOARCH=${TARGETARCH} ./build.sh -o qclient
RUN cp qclient /usr/bin

# -----------------------------------------------------------------------------
Expand Down
Loading