fix: match CI query count to site by computing total from uploadable results#107
Open
fix: match CI query count to site by computing total from uploadable results#107
Conversation
The `total` counter was incrementing during log parsing, counting raw entries before deduplication and optimization. This caused the CI comment to show a different query count than the site, which only displays queries with uploadable states (improvements_available, no_improvement_found, error). Compute `total` from the deduplicated, optimized results filtered to uploadable states so the CI comment and site always agree. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Query Doctor Analysis
2 queries analyzed
2 pre-existing issues
SELECT "guests"."id", "guests"."session_id", "guests"."username", "guests"."avatar_path", "guests"."color", "guests"."side", "guests"."audio_recording_path", "guests"."audio_recording_public", "gue...
indexassets(event_id, uploader_id, inserted_at desc)
cost 15,918 → 1,631 (90% reduction)SELECT * FROM guest_ip_addresses WHERE ip_address = '127.0.0.1';
indexguest_ip_addresses(ip_address)
cost 126 → 9 (93% reduction)
Using assumed statistics (10000 rows/table). For better results, sync production stats.
Extract UPLOADABLE_STATES and countUploadableQueries as exported functions so they can be tested. Tests verify: - Only improvements_available, no_improvement_found, error are counted - not_supported, timeout, waiting, optimizing are excluded - countUploadableQueries agrees with buildQueries for every state Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
veksen
force-pushed
the
veksen/ci-vs-site-query-count
branch
from
4825d2a to
2d5aaa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
totalcounter that incremented during log parsing (counting raw, pre-dedup entries)totalafter optimization from deduplicated results filtered to uploadable states (improvements_available,no_improvement_found,error)Test plan
🤖 Generated with Claude Code