STAR: iSWAP.request_is_parked, and two channels a pitch apart are not too close - #1346
Merged
Merged
Conversation
BioCam
force-pushed
the
star-iswap-is-parked
branch
from
September 24, 2026 23:26
4cfc574 to
f982d56
Compare
BioCam
force-pushed
the
star-iswap-is-parked
branch
from
September 25, 2026 07:25
f982d56 to
e75f30a
Compare
rickwierenga
added this pull request to stack #1357
September 25, 2026 07:50
rickwierenga
force-pushed
the
star-iswap-is-parked
branch
2 times, most recently
from
September 25, 2026 10:09
732c63f to
b438013
Compare
rickwierenga
force-pushed
the
star-iswap-is-parked
branch
5 times, most recently
from
September 25, 2026 10:17
6cf6376 to
e478b08
Compare
… too close The name answers a yes/no question, so it reads as one: `request_is_parked`, callers and tests renamed with it. Spots exactly one pitch apart were refused as too close for a tip command: the Y difference of two float positions is off by float error (130.7 - 121.7 is 8.999999999999986), while the command carries tenths. The gap is rounded to 0.1 mm before it is compared. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rickwierenga
force-pushed
the
star-iswap-is-parked
branch
from
September 25, 2026 10:18
e478b08 to
369d902
Compare
rickwierenga
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iSWAP.request_parkedanswers a yes/no question, and_tip_command_positionsrefused two spots exactly one channel pitch apart:130.7 - 121.7is8.999999999999986in floating point, below the 9.0 mm minimum, although the command carries tenths.iSWAP.request_parkedisrequest_is_parked; every caller and test follows. No alias._tip_command_positionsrounds the Y gap to 0.1 mm before comparing it with the pair's minimum spacing, and the refusal names the rounded gap.Tests: spots a pitch apart in floating point go out in one command.
🤖 Generated with Claude Code