Make ATTError an extensible struct#201
Open
dpogueproton wants to merge 1 commit intoPureSwift:masterfrom
Open
Conversation
colemancda
requested changes
Apr 13, 2026
| public struct ATTError: RawRepresentable, Equatable, Hashable, Error { | ||
| public typealias RawValue = UInt8 | ||
|
|
||
| enum Code: UInt8 { |
Member
There was a problem hiding this comment.
Can you remove the Code enum and change that to static var cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #200.
What does this PR Do?
Converts
ATTErrorfrom an enum to a struct to allow for extending with additional application-specific error codes.ATTError(rawValue: 0)returns nil because 0x00 is the success code.All the pre-defined errors are set up so they return a non-Optional ATTError, and this should be API compatible with all existing code.
Where should the reviewer start?
ATTError.swift